fix #1075 使用EngineGroup实现一主多从集群，无法从Master执行Sql查询，并且总是从Slave查询。 #1076

lunny · 2018-08-20T07:13:35Z

liumingmin commented

2018-08-20 07:13:35 +00:00

(Migrated from github.com)

fix #1075 使用EngineGroup实现一主多从集群，无法从Master执行Sql查询，并且总是从Slave查询。

codecov-io commented

2018-08-20 07:30:58 +00:00

(Migrated from github.com)

Codecov Report

Merging #1076 into master will decrease coverage by 0.03%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##           master    #1076      +/-   ##
==========================================
- Coverage    54.3%   54.27%   -0.04%     
==========================================
  Files          41       41              
  Lines        7564     7571       +7     
==========================================
+ Hits         4108     4109       +1     
- Misses       2937     2942       +5     
- Partials      519      520       +1

Impacted Files	Coverage Δ
engine.go	`61.38% <0%> (-0.35%)`	⬇️
session.go	`56.38% <100%> (+0.08%)`	⬆️
session_raw.go	`56.29% <16.66%> (-1.28%)`	⬇️
xorm.go	`64.61% <0%> (ø)`	⬆️
dialect_mysql.go	`59.39% <0%> (ø)`	⬆️
session_get.go	`75.57% <0%> (+1.13%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e21af9...42e18eb. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1076?src=pr&el=h1) Report > Merging [#1076](https://codecov.io/gh/go-xorm/xorm/pull/1076?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/4e21af912258f4b39578a6c869c74a5eb9ea2791?src=pr&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `16.66%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/1076/graphs/tree.svg?width=650&token=yB5nO1krEe&height=150&src=pr)](https://codecov.io/gh/go-xorm/xorm/pull/1076?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1076 +/- ## ========================================== - Coverage 54.3% 54.27% -0.04% ========================================== Files 41 41 Lines 7564 7571 +7 ========================================== + Hits 4108 4109 +1 - Misses 2937 2942 +5 - Partials 519 520 +1 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/1076?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [engine.go](https://codecov.io/gh/go-xorm/xorm/pull/1076/diff?src=pr&el=tree#diff-ZW5naW5lLmdv) | `61.38% <0%> (-0.35%)` | :arrow_down: | | [session.go](https://codecov.io/gh/go-xorm/xorm/pull/1076/diff?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `56.38% <100%> (+0.08%)` | :arrow_up: | | [session\_raw.go](https://codecov.io/gh/go-xorm/xorm/pull/1076/diff?src=pr&el=tree#diff-c2Vzc2lvbl9yYXcuZ28=) | `56.29% <16.66%> (-1.28%)` | :arrow_down: | | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/1076/diff?src=pr&el=tree#diff-eG9ybS5nbw==) | `64.61% <0%> (ø)` | :arrow_up: | | [dialect\_mysql.go](https://codecov.io/gh/go-xorm/xorm/pull/1076/diff?src=pr&el=tree#diff-ZGlhbGVjdF9teXNxbC5nbw==) | `59.39% <0%> (ø)` | :arrow_up: | | [session\_get.go](https://codecov.io/gh/go-xorm/xorm/pull/1076/diff?src=pr&el=tree#diff-c2Vzc2lvbl9nZXQuZ28=) | `75.57% <0%> (+1.13%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1076?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1076?src=pr&el=footer). Last update [4e21af9...42e18eb](https://codecov.io/gh/go-xorm/xorm/pull/1076?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny referenced this issue from a commit

2019-10-21 05:47:01 +00:00

fix #1075 and replace #1076 (#1101) * fix #1075 and replace #1076 * fix bug when session resue

continuous-integration/drone/push Build is failing

Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#1076