Add more methods for EngineInterface #1091

lunny · 2018-09-06T12:56:57Z

lunny commented

2018-09-06 12:56:57 +00:00

No description provided.

codecov-io commented

2018-09-06 13:13:47 +00:00

(Migrated from github.com)

Codecov Report

Merging #1091 into master will increase coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1091      +/-   ##
==========================================
+ Coverage    54.3%   54.32%   +0.01%     
==========================================
  Files          41       40       -1     
  Lines        7564     7562       -2     
==========================================
  Hits         4108     4108              
+ Misses       2937     2936       -1     
+ Partials      519      518       -1

Impacted Files	Coverage Δ
xorm.go	`64.61% <ø> (ø)`	⬆️
engine_group.go	`0% <0%> (ø)`	⬆️
engine.go	`61.59% <0%> (-0.14%)`	⬇️
dialect_mysql.go	`59.39% <0%> (ø)`	⬆️
session_get.go	`75.57% <0%> (+1.13%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e21af9...2e373f9. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1091?src=pr&el=h1) Report > Merging [#1091](https://codecov.io/gh/go-xorm/xorm/pull/1091?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/4e21af912258f4b39578a6c869c74a5eb9ea2791?src=pr&el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `0%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/1091/graphs/tree.svg?width=650&token=yB5nO1krEe&height=150&src=pr)](https://codecov.io/gh/go-xorm/xorm/pull/1091?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1091 +/- ## ========================================== + Coverage 54.3% 54.32% +0.01% ========================================== Files 41 40 -1 Lines 7564 7562 -2 ========================================== Hits 4108 4108 + Misses 2937 2936 -1 + Partials 519 518 -1 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/1091?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/1091/diff?src=pr&el=tree#diff-eG9ybS5nbw==) | `64.61% <ø> (ø)` | :arrow_up: | | [engine\_group.go](https://codecov.io/gh/go-xorm/xorm/pull/1091/diff?src=pr&el=tree#diff-ZW5naW5lX2dyb3VwLmdv) | `0% <0%> (ø)` | :arrow_up: | | [engine.go](https://codecov.io/gh/go-xorm/xorm/pull/1091/diff?src=pr&el=tree#diff-ZW5naW5lLmdv) | `61.59% <0%> (-0.14%)` | :arrow_down: | | [dialect\_mysql.go](https://codecov.io/gh/go-xorm/xorm/pull/1091/diff?src=pr&el=tree#diff-ZGlhbGVjdF9teXNxbC5nbw==) | `59.39% <0%> (ø)` | :arrow_up: | | [session\_get.go](https://codecov.io/gh/go-xorm/xorm/pull/1091/diff?src=pr&el=tree#diff-c2Vzc2lvbl9nZXQuZ28=) | `75.57% <0%> (+1.13%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1091?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1091?src=pr&el=footer). Last update [4e21af9...2e373f9](https://codecov.io/gh/go-xorm/xorm/pull/1091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny referenced this issue from a commit

2019-10-21 05:47:01 +00:00

Add more methods for EngineInterface (#1091) * add more methods for EngineInterface * more interfaces

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#1091