Fix bug in sqlite db-name parsing #1096

betacat0 · 2018-09-11T14:39:50Z

betacat0 commented

2018-09-11 14:39:50 +00:00

No description provided.

codecov-io commented

2018-09-11 14:57:02 +00:00

(Migrated from github.com)

Codecov Report

Merging #1096 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #1096   +/-   ##
=======================================
  Coverage   54.32%   54.32%           
=======================================
  Files          40       41    +1     
  Lines        7564     7564           
=======================================
  Hits         4109     4109           
  Misses       2937     2937           
  Partials      518      518

Impacted Files	Coverage Δ
dialect_sqlite3.go	`77.29% <0%> (-0.76%)`	⬇️
xorm.go	`66.15% <0%> (ø)`	⬆️
engine_group.go	`0% <0%> (ø)`	⬆️
dialect_mysql.go	`59.39% <0%> (ø)`	⬆️
engine_maxlife.go	`0% <0%> (ø)`
engine.go	`61.72% <0%> (+0.13%)`	⬆️
session_get.go	`75.57% <0%> (+1.13%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 270035c...eb6934c. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1096?src=pr&el=h1) Report > Merging [#1096](https://codecov.io/gh/go-xorm/xorm/pull/1096?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/270035c70f8ffb88e6a456e1000b71d0c2d19304?src=pr&el=desc) will **not change** coverage. > The diff coverage is `0%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/1096/graphs/tree.svg?width=650&token=yB5nO1krEe&height=150&src=pr)](https://codecov.io/gh/go-xorm/xorm/pull/1096?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1096 +/- ## ======================================= Coverage 54.32% 54.32% ======================================= Files 40 41 +1 Lines 7564 7564 ======================================= Hits 4109 4109 Misses 2937 2937 Partials 518 518 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/1096?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [dialect\_sqlite3.go](https://codecov.io/gh/go-xorm/xorm/pull/1096/diff?src=pr&el=tree#diff-ZGlhbGVjdF9zcWxpdGUzLmdv) | `77.29% <0%> (-0.76%)` | :arrow_down: | | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/1096/diff?src=pr&el=tree#diff-eG9ybS5nbw==) | `66.15% <0%> (ø)` | :arrow_up: | | [engine\_group.go](https://codecov.io/gh/go-xorm/xorm/pull/1096/diff?src=pr&el=tree#diff-ZW5naW5lX2dyb3VwLmdv) | `0% <0%> (ø)` | :arrow_up: | | [dialect\_mysql.go](https://codecov.io/gh/go-xorm/xorm/pull/1096/diff?src=pr&el=tree#diff-ZGlhbGVjdF9teXNxbC5nbw==) | `59.39% <0%> (ø)` | :arrow_up: | | [engine\_maxlife.go](https://codecov.io/gh/go-xorm/xorm/pull/1096/diff?src=pr&el=tree#diff-ZW5naW5lX21heGxpZmUuZ28=) | `0% <0%> (ø)` | | | [engine.go](https://codecov.io/gh/go-xorm/xorm/pull/1096/diff?src=pr&el=tree#diff-ZW5naW5lLmdv) | `61.72% <0%> (+0.13%)` | :arrow_up: | | [session\_get.go](https://codecov.io/gh/go-xorm/xorm/pull/1096/diff?src=pr&el=tree#diff-c2Vzc2lvbl9nZXQuZ28=) | `75.57% <0%> (+1.13%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1096?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1096?src=pr&el=footer). Last update [270035c...eb6934c](https://codecov.io/gh/go-xorm/xorm/pull/1096?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny referenced this issue from a commit

2019-10-21 05:47:01 +00:00

fix bug in sqlite db name parsing (#1096)

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#1096