Add version uint type support #1125

lunny · 2018-10-26T05:07:55Z

marshalys commented

2018-10-26 05:07:55 +00:00

(Migrated from github.com)

fix panic when use version with uint32 type #1124

codecov-io commented

2018-10-26 05:24:15 +00:00

(Migrated from github.com)

Codecov Report

Merging #1125 into master will increase coverage by 0.04%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##           master    #1125      +/-   ##
==========================================
+ Coverage   54.64%   54.69%   +0.04%     
==========================================
  Files          42       42              
  Lines        7640     7646       +6     
==========================================
+ Hits         4175     4182       +7     
+ Misses       2937     2935       -2     
- Partials      528      529       +1

Impacted Files	Coverage Δ
session.go	`57.83% <100%> (+0.49%)`	⬆️
session_update.go	`52.54% <50%> (ø)`	⬆️
session_insert.go	`60.45% <66.66%> (ø)`	⬆️
xorm.go	`64.61% <0%> (-1.54%)`	⬇️
session_cols.go	`93.47% <0%> (+2.17%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f39c59...a7e2cb5. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1125?src=pr&el=h1) Report > Merging [#1125](https://codecov.io/gh/go-xorm/xorm/pull/1125?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/1f39c590c64924f358c0d89016ac9b2bb84e9125?src=pr&el=desc) will **increase** coverage by `0.04%`. > The diff coverage is `81.81%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/1125/graphs/tree.svg?width=650&token=yB5nO1krEe&height=150&src=pr)](https://codecov.io/gh/go-xorm/xorm/pull/1125?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1125 +/- ## ========================================== + Coverage 54.64% 54.69% +0.04% ========================================== Files 42 42 Lines 7640 7646 +6 ========================================== + Hits 4175 4182 +7 + Misses 2937 2935 -2 - Partials 528 529 +1 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/1125?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [session.go](https://codecov.io/gh/go-xorm/xorm/pull/1125/diff?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `57.83% <100%> (+0.49%)` | :arrow_up: | | [session\_update.go](https://codecov.io/gh/go-xorm/xorm/pull/1125/diff?src=pr&el=tree#diff-c2Vzc2lvbl91cGRhdGUuZ28=) | `52.54% <50%> (ø)` | :arrow_up: | | [session\_insert.go](https://codecov.io/gh/go-xorm/xorm/pull/1125/diff?src=pr&el=tree#diff-c2Vzc2lvbl9pbnNlcnQuZ28=) | `60.45% <66.66%> (ø)` | :arrow_up: | | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/1125/diff?src=pr&el=tree#diff-eG9ybS5nbw==) | `64.61% <0%> (-1.54%)` | :arrow_down: | | [session\_cols.go](https://codecov.io/gh/go-xorm/xorm/pull/1125/diff?src=pr&el=tree#diff-c2Vzc2lvbl9jb2xzLmdv) | `93.47% <0%> (+2.17%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1125?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1125?src=pr&el=footer). Last update [1f39c59...a7e2cb5](https://codecov.io/gh/go-xorm/xorm/pull/1125?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny commented

2018-10-27 13:20:24 +00:00

Thanks!

marshalys commented

2018-10-28 06:39:34 +00:00

(Migrated from github.com)

it's my pleasure

lunny referenced this issue from a commit

2019-10-21 05:47:01 +00:00

Add version uint type support (#1125) * fix panic when use version with uint32 type * fix panic when use version with uint32 type * Code refactoring

Sign in to join this conversation.

No reviewers