Fix the problem with lost omitted columns when performing Omit.Insert(array ...) #1146

betacat0 · 2018-11-13T15:25:56Z

betacat0 commented

2018-11-13 15:25:56 +00:00

fix https://github.com/go-xorm/xorm/issues/1143

codecov-io commented

2018-11-13 15:42:53 +00:00

(Migrated from github.com)

Codecov Report

Merging #1146 into master will increase coverage by 0.07%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1146      +/-   ##
==========================================
+ Coverage   54.69%   54.77%   +0.07%     
==========================================
  Files          42       42              
  Lines        7646     7655       +9     
==========================================
+ Hits         4182     4193      +11     
+ Misses       2935     2934       -1     
+ Partials      529      528       -1

Impacted Files	Coverage Δ
session_insert.go	`61.84% <100%> (+1.38%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b07c406...6b3b187. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1146?src=pr&el=h1) Report > Merging [#1146](https://codecov.io/gh/go-xorm/xorm/pull/1146?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/b07c4067034594d1a43e314b10153ff9cfc58f86?src=pr&el=desc) will **increase** coverage by `0.07%`. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/1146/graphs/tree.svg?width=650&token=yB5nO1krEe&height=150&src=pr)](https://codecov.io/gh/go-xorm/xorm/pull/1146?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1146 +/- ## ========================================== + Coverage 54.69% 54.77% +0.07% ========================================== Files 42 42 Lines 7646 7655 +9 ========================================== + Hits 4182 4193 +11 + Misses 2935 2934 -1 + Partials 529 528 -1 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/1146?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [session\_insert.go](https://codecov.io/gh/go-xorm/xorm/pull/1146/diff?src=pr&el=tree#diff-c2Vzc2lvbl9pbnNlcnQuZ28=) | `61.84% <100%> (+1.38%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1146?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1146?src=pr&el=footer). Last update [b07c406...6b3b187](https://codecov.io/gh/go-xorm/xorm/pull/1146?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

betacat0 commented

2018-11-13 15:57:13 +00:00

I think it's just a temporary solution for this problem, whereas we should dive into the function resetStatement and generalize to other batch operations.

I think it's just a temporary solution for this problem, whereas we should dive into the function `resetStatement ` and generalize to other batch operations.

lunny commented

2019-01-21 08:15:08 +00:00

Please resolve conflict.

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#1146