fix #1066 #1147

Closed
eleztian wants to merge 1 commits from eleztian/fix/time into master
eleztian commented 2018-11-13 15:47:40 +00:00 (Migrated from github.com)

use default value or "0001-01-01 00:00:00" when time is zero

use default value or "0001-01-01 00:00:00" when time is zero
codecov-io commented 2018-11-13 16:05:07 +00:00 (Migrated from github.com)

Codecov Report

Merging #1147 into master will decrease coverage by 0.38%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1147      +/-   ##
=========================================
- Coverage   54.69%   54.3%   -0.39%     
=========================================
  Files          42      41       -1     
  Lines        7646    7566      -80     
=========================================
- Hits         4182    4109      -73     
- Misses       2935    2939       +4     
+ Partials      529     518      -11
Impacted Files Coverage Δ
engine.go 61.59% <0%> (ø) ⬆️
context.go 0% <0%> (-77.78%) ⬇️
session_get.go 74.43% <0%> (-2.44%) ⬇️
session_cols.go 91.3% <0%> (-2.18%) ⬇️
session.go 56.29% <0%> (-1.54%) ⬇️
statement.go 66.84% <0%> (-0.05%) ⬇️
engine_group.go 0% <0%> (ø) ⬆️
context_cache.go
transaction.go
engine_maxlife.go 0% <0%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b07c406...1663d9f. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1147?src=pr&el=h1) Report > Merging [#1147](https://codecov.io/gh/go-xorm/xorm/pull/1147?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/b07c4067034594d1a43e314b10153ff9cfc58f86?src=pr&el=desc) will **decrease** coverage by `0.38%`. > The diff coverage is `0%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/1147/graphs/tree.svg?width=650&token=yB5nO1krEe&height=150&src=pr)](https://codecov.io/gh/go-xorm/xorm/pull/1147?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1147 +/- ## ========================================= - Coverage 54.69% 54.3% -0.39% ========================================= Files 42 41 -1 Lines 7646 7566 -80 ========================================= - Hits 4182 4109 -73 - Misses 2935 2939 +4 + Partials 529 518 -11 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/1147?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [engine.go](https://codecov.io/gh/go-xorm/xorm/pull/1147/diff?src=pr&el=tree#diff-ZW5naW5lLmdv) | `61.59% <0%> (ø)` | :arrow_up: | | [context.go](https://codecov.io/gh/go-xorm/xorm/pull/1147/diff?src=pr&el=tree#diff-Y29udGV4dC5nbw==) | `0% <0%> (-77.78%)` | :arrow_down: | | [session\_get.go](https://codecov.io/gh/go-xorm/xorm/pull/1147/diff?src=pr&el=tree#diff-c2Vzc2lvbl9nZXQuZ28=) | `74.43% <0%> (-2.44%)` | :arrow_down: | | [session\_cols.go](https://codecov.io/gh/go-xorm/xorm/pull/1147/diff?src=pr&el=tree#diff-c2Vzc2lvbl9jb2xzLmdv) | `91.3% <0%> (-2.18%)` | :arrow_down: | | [session.go](https://codecov.io/gh/go-xorm/xorm/pull/1147/diff?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `56.29% <0%> (-1.54%)` | :arrow_down: | | [statement.go](https://codecov.io/gh/go-xorm/xorm/pull/1147/diff?src=pr&el=tree#diff-c3RhdGVtZW50Lmdv) | `66.84% <0%> (-0.05%)` | :arrow_down: | | [engine\_group.go](https://codecov.io/gh/go-xorm/xorm/pull/1147/diff?src=pr&el=tree#diff-ZW5naW5lX2dyb3VwLmdv) | `0% <0%> (ø)` | :arrow_up: | | [context\_cache.go](https://codecov.io/gh/go-xorm/xorm/pull/1147/diff?src=pr&el=tree#diff-Y29udGV4dF9jYWNoZS5nbw==) | | | | [transaction.go](https://codecov.io/gh/go-xorm/xorm/pull/1147/diff?src=pr&el=tree#diff-dHJhbnNhY3Rpb24uZ28=) | | | | [engine\_maxlife.go](https://codecov.io/gh/go-xorm/xorm/pull/1147/diff?src=pr&el=tree#diff-ZW5naW5lX21heGxpZmUuZ28=) | `0% <0%> (ø)` | | | ... and [4 more](https://codecov.io/gh/go-xorm/xorm/pull/1147/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1147?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1147?src=pr&el=footer). Last update [b07c406...1663d9f](https://codecov.io/gh/go-xorm/xorm/pull/1147?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
lunny added this to the 1.0.0 milestone 2020-02-24 06:46:18 +00:00

We really needs test.

We really needs test.
lunny modified the milestone from 1.0.0 to 1.1.1 2020-03-01 13:25:35 +00:00
lunny referenced this issue from a commit 2021-06-09 02:00:15 +00:00
lunny removed this from the 1.1.1 milestone 2021-06-09 02:00:58 +00:00
lunny closed this pull request 2021-06-09 02:01:01 +00:00
lunny deleted branch eleztian/fix/time 2021-06-09 02:01:07 +00:00

Pull request closed

Sign in to join this conversation.
No description provided.