Add lasterror on statement to return errors when chain operations #1151

lunny · 2018-11-21T01:38:41Z

lunny commented

2018-11-21 01:38:41 +00:00

should fix #1134

codecov-io commented

2018-11-21 03:05:43 +00:00

(Migrated from github.com)

Codecov Report

Merging #1151 into master will decrease coverage by 0.01%.
The diff coverage is 25%.

@@            Coverage Diff             @@
##           master    #1151      +/-   ##
==========================================
- Coverage   51.42%   51.41%   -0.02%     
==========================================
  Files          43       43              
  Lines        7663     7677      +14     
==========================================
+ Hits         3941     3947       +6     
- Misses       3210     3214       +4     
- Partials      512      516       +4

Impacted Files	Coverage Δ
error.go	`50% <ø> (ø)`	⬆️
session_exist.go	`59.18% <0%> (-2.52%)`	⬇️
session_iterate.go	`76.92% <0%> (-3.08%)`	⬇️
session_get.go	`75.83% <0%> (-1.04%)`	⬇️
session_delete.go	`58.22% <0%> (-0.75%)`	⬇️
session_find.go	`67.91% <0%> (-0.43%)`	⬇️
session_update.go	`50.63% <100%> (+0.31%)`	⬆️
statement.go	`67.09% <50%> (+0.21%)`	⬆️
xorm.go	`63.63% <0%> (+1.51%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58b4f7f...b5aa106. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1151?src=pr&el=h1) Report > Merging [#1151](https://codecov.io/gh/go-xorm/xorm/pull/1151?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/58b4f7f1099cc6282bd5f626fc7c457ec44fac5a?src=pr&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `25%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/1151/graphs/tree.svg?width=650&token=yB5nO1krEe&height=150&src=pr)](https://codecov.io/gh/go-xorm/xorm/pull/1151?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1151 +/- ## ========================================== - Coverage 51.42% 51.41% -0.02% ========================================== Files 43 43 Lines 7663 7677 +14 ========================================== + Hits 3941 3947 +6 - Misses 3210 3214 +4 - Partials 512 516 +4 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/1151?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [error.go](https://codecov.io/gh/go-xorm/xorm/pull/1151/diff?src=pr&el=tree#diff-ZXJyb3IuZ28=) | `50% <ø> (ø)` | :arrow_up: | | [session\_exist.go](https://codecov.io/gh/go-xorm/xorm/pull/1151/diff?src=pr&el=tree#diff-c2Vzc2lvbl9leGlzdC5nbw==) | `59.18% <0%> (-2.52%)` | :arrow_down: | | [session\_iterate.go](https://codecov.io/gh/go-xorm/xorm/pull/1151/diff?src=pr&el=tree#diff-c2Vzc2lvbl9pdGVyYXRlLmdv) | `76.92% <0%> (-3.08%)` | :arrow_down: | | [session\_get.go](https://codecov.io/gh/go-xorm/xorm/pull/1151/diff?src=pr&el=tree#diff-c2Vzc2lvbl9nZXQuZ28=) | `75.83% <0%> (-1.04%)` | :arrow_down: | | [session\_delete.go](https://codecov.io/gh/go-xorm/xorm/pull/1151/diff?src=pr&el=tree#diff-c2Vzc2lvbl9kZWxldGUuZ28=) | `58.22% <0%> (-0.75%)` | :arrow_down: | | [session\_find.go](https://codecov.io/gh/go-xorm/xorm/pull/1151/diff?src=pr&el=tree#diff-c2Vzc2lvbl9maW5kLmdv) | `67.91% <0%> (-0.43%)` | :arrow_down: | | [session\_update.go](https://codecov.io/gh/go-xorm/xorm/pull/1151/diff?src=pr&el=tree#diff-c2Vzc2lvbl91cGRhdGUuZ28=) | `50.63% <100%> (+0.31%)` | :arrow_up: | | [statement.go](https://codecov.io/gh/go-xorm/xorm/pull/1151/diff?src=pr&el=tree#diff-c3RhdGVtZW50Lmdv) | `67.09% <50%> (+0.21%)` | :arrow_up: | | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/1151/diff?src=pr&el=tree#diff-eG9ybS5nbw==) | `63.63% <0%> (+1.51%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1151?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1151?src=pr&el=footer). Last update [58b4f7f...b5aa106](https://codecov.io/gh/go-xorm/xorm/pull/1151?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny referenced this issue from a commit

2019-10-21 05:47:01 +00:00

Add lasterror on statement to return errors when chain operations (#1151) * add lasterror on statement to return errors when chain operations * add tests for last error * refactor error

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#1151