Make json handler as interface #1248

lunny · 2019-03-13T06:14:46Z

lunny commented

2019-03-13 06:14:46 +00:00

should resolve #1218

codecov-io commented

2019-03-13 06:19:37 +00:00

(Migrated from github.com)

Codecov Report

Merging #1248 into master will increase coverage by 0.03%.
The diff coverage is 33.33%.

@@            Coverage Diff            @@
##           master   #1248      +/-   ##
=========================================
+ Coverage   57.37%   57.4%   +0.03%     
=========================================
  Files          43      44       +1     
  Lines        7807    7811       +4     
=========================================
+ Hits         4479    4484       +5     
  Misses       2772    2772              
+ Partials      556     555       -1

Impacted Files	Coverage Δ
json.go	`100% <100%> (ø)`
session.go	`58.49% <11.11%> (ø)`	⬆️
engine_cond.go	`56.29% <25%> (ø)`	⬆️
session_convert.go	`22.29% <30%> (ø)`	⬆️
statement.go	`68.3% <33.33%> (ø)`	⬆️
xorm.go	`69.69% <0%> (+1.51%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c2d47e...4fc085a. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1248?src=pr&el=h1) Report > Merging [#1248](https://codecov.io/gh/go-xorm/xorm/pull/1248?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/1c2d47e0da970d1b3214cd57e6ab9e9b81556ab2?src=pr&el=desc) will **increase** coverage by `0.03%`. > The diff coverage is `33.33%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/1248/graphs/tree.svg?width=650&token=yB5nO1krEe&height=150&src=pr)](https://codecov.io/gh/go-xorm/xorm/pull/1248?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1248 +/- ## ========================================= + Coverage 57.37% 57.4% +0.03% ========================================= Files 43 44 +1 Lines 7807 7811 +4 ========================================= + Hits 4479 4484 +5 Misses 2772 2772 + Partials 556 555 -1 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/1248?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [json.go](https://codecov.io/gh/go-xorm/xorm/pull/1248/diff?src=pr&el=tree#diff-anNvbi5nbw==) | `100% <100%> (ø)` | | | [session.go](https://codecov.io/gh/go-xorm/xorm/pull/1248/diff?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `58.49% <11.11%> (ø)` | :arrow_up: | | [engine\_cond.go](https://codecov.io/gh/go-xorm/xorm/pull/1248/diff?src=pr&el=tree#diff-ZW5naW5lX2NvbmQuZ28=) | `56.29% <25%> (ø)` | :arrow_up: | | [session\_convert.go](https://codecov.io/gh/go-xorm/xorm/pull/1248/diff?src=pr&el=tree#diff-c2Vzc2lvbl9jb252ZXJ0Lmdv) | `22.29% <30%> (ø)` | :arrow_up: | | [statement.go](https://codecov.io/gh/go-xorm/xorm/pull/1248/diff?src=pr&el=tree#diff-c3RhdGVtZW50Lmdv) | `68.3% <33.33%> (ø)` | :arrow_up: | | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/1248/diff?src=pr&el=tree#diff-eG9ybS5nbw==) | `69.69% <0%> (+1.51%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1248?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1248?src=pr&el=footer). Last update [1c2d47e...4fc085a](https://codecov.io/gh/go-xorm/xorm/pull/1248?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny referenced this issue from a commit

2019-10-21 05:47:02 +00:00

make json as interface (#1248)

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#1248