Let defaultJsonHandler be a json handler interface. #1269

lunny · 2019-04-10T12:07:32Z

hirust commented

2019-04-10 12:07:32 +00:00

(Migrated from github.com)

Let defaultJsonHandler be a json handler interface.

codecov-io commented

2019-04-10 12:12:03 +00:00

(Migrated from github.com)

Codecov Report

Merging #1269 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1269      +/-   ##
==========================================
+ Coverage   57.36%   57.37%   +0.01%     
==========================================
  Files          44       44              
  Lines        7815     7815              
==========================================
+ Hits         4483     4484       +1     
  Misses       2776     2776              
+ Partials      556      555       -1

Impacted Files	Coverage Δ
json.go	`100% <ø> (ø)`	⬆️
xorm.go	`69.69% <0%> (+1.51%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06528a4...dd978f3. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1269?src=pr&el=h1) Report > Merging [#1269](https://codecov.io/gh/go-xorm/xorm/pull/1269?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/06528a4d83e70fd6879c9453884af15c3ebd45af?src=pr&el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/1269/graphs/tree.svg?width=650&token=yB5nO1krEe&height=150&src=pr)](https://codecov.io/gh/go-xorm/xorm/pull/1269?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1269 +/- ## ========================================== + Coverage 57.36% 57.37% +0.01% ========================================== Files 44 44 Lines 7815 7815 ========================================== + Hits 4483 4484 +1 Misses 2776 2776 + Partials 556 555 -1 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/1269?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [json.go](https://codecov.io/gh/go-xorm/xorm/pull/1269/diff?src=pr&el=tree#diff-anNvbi5nbw==) | `100% <ø> (ø)` | :arrow_up: | | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/1269/diff?src=pr&el=tree#diff-eG9ybS5nbw==) | `69.69% <0%> (+1.51%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1269?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1269?src=pr&el=footer). Last update [06528a4...dd978f3](https://codecov.io/gh/go-xorm/xorm/pull/1269?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny referenced this issue from a commit

2019-10-21 05:47:02 +00:00

Let defaultJsonHandler be a json handler interface. (#1269)

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#1269