xorm/xorm
xorm/xorm
63
356
Fork 206
Code Issues 370 Pull Requests 18 Actions 4 Releases 35 Activity

Allow adding prefix for fields with extends tag #1284

Merged
mskrip merged 2 commits from same-type-extends into master 2019-06-23 02:44:45 +00:00
Conversation 12 Commits 2 Files Changed 3 +150 -1
mskrip commented 2019-04-30 10:22:52 +00:00 (Migrated from github.com)
Copy Link

Added new syntax like extends('Prefix') to enable matching all
extended fields as PrefixFieldName.

Close go-xorm/xorm#1270

Added new syntax like `extends('Prefix')` to enable matching all extended fields as `PrefixFieldName`. Close go-xorm/xorm#1270
codecov-io commented 2019-04-30 10:27:42 +00:00 (Migrated from github.com)
Copy Link

Codecov Report

Merging #1284 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1284      +/-   ##
==========================================
+ Coverage   57.37%   57.44%   +0.06%     
==========================================
  Files          44       44              
  Lines        7813     7837      +24     
==========================================
+ Hits         4483     4502      +19     
- Misses       2773     2777       +4     
- Partials      557      558       +1
Impacted Files Coverage Δ
tag.go 79.31% <100%> (+2.21%) ⬆️
engine.go 61.79% <100%> (+0.21%) ⬆️
rows.go 52.38% <0%> (-3.76%) ⬇️
session_exist.go 62.26% <0%> (-0.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1b4f83...7842419. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1284?src=pr&el=h1) Report > Merging [#1284](https://codecov.io/gh/go-xorm/xorm/pull/1284?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/f1b4f83684597bbd71ee21462f7f8cd85c9bbf66?src=pr&el=desc) will **increase** coverage by `0.06%`. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/1284/graphs/tree.svg?width=650&token=yB5nO1krEe&height=150&src=pr)](https://codecov.io/gh/go-xorm/xorm/pull/1284?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1284 +/- ## ========================================== + Coverage 57.37% 57.44% +0.06% ========================================== Files 44 44 Lines 7813 7837 +24 ========================================== + Hits 4483 4502 +19 - Misses 2773 2777 +4 - Partials 557 558 +1 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/1284?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [tag.go](https://codecov.io/gh/go-xorm/xorm/pull/1284/diff?src=pr&el=tree#diff-dGFnLmdv) | `79.31% <100%> (+2.21%)` | :arrow_up: | | [engine.go](https://codecov.io/gh/go-xorm/xorm/pull/1284/diff?src=pr&el=tree#diff-ZW5naW5lLmdv) | `61.79% <100%> (+0.21%)` | :arrow_up: | | [rows.go](https://codecov.io/gh/go-xorm/xorm/pull/1284/diff?src=pr&el=tree#diff-cm93cy5nbw==) | `52.38% <0%> (-3.76%)` | :arrow_down: | | [session\_exist.go](https://codecov.io/gh/go-xorm/xorm/pull/1284/diff?src=pr&el=tree#diff-c2Vzc2lvbl9leGlzdC5nbw==) | `62.26% <0%> (-0.7%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1284?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1284?src=pr&el=footer). Last update [f1b4f83...7842419](https://codecov.io/gh/go-xorm/xorm/pull/1284?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
lunny commented 2019-05-01 00:04:31 +00:00
Copy Link

Join Table Alias Name or prefix of the name, which is better?

SELECT <extends_name>.width, <extends_name>.height

instead of

SELECT <extends_name>width, <extends_name>height
Join Table Alias Name or prefix of the name, which is better? ``` SELECT <extends_name>.width, <extends_name>.height ``` instead of ``` SELECT <extends_name>width, <extends_name>height ```
mskrip commented 2019-05-01 17:17:20 +00:00 (Migrated from github.com)
Copy Link

IMO having just prefix is better here since it refers to what the column name of the query result should be changed to, it doesn't have to have anything in common with the table (the prefix I mean).

IMO having just prefix is better here since it refers to what the column name of the query result should be changed to, it doesn't have to have anything in common with the table (the prefix I mean).
mskrip commented 2019-05-14 08:19:08 +00:00 (Migrated from github.com)
Copy Link

Sorry to bother you, but would I be able to get an ETA on this review? This is kind of a blocking change for me.

Sorry to bother you, but would I be able to get an ETA on this review? This is kind of a blocking change for me.
lunny commented 2019-05-15 12:33:50 +00:00
Copy Link

How to handle SizeClosed *Size xorm:"extends('')"` ?

How to handle `SizeClosed *Size `xorm:"extends('')"` ?
mskrip commented 2019-05-16 11:31:58 +00:00 (Migrated from github.com)
Copy Link

Maybe as if there was no argument? So the same as just xorm:"extends" ?

Maybe as if there was no argument? So the same as just `xorm:"extends"` ?
lunny commented 2019-05-17 02:33:56 +00:00
Copy Link

@mskrip I think it's reasonable.

@mskrip I think it's reasonable.
mskrip commented 2019-05-21 09:19:55 +00:00 (Migrated from github.com)
Copy Link

@lunny Added test for that case

@lunny Added test for that case
mskrip commented 2019-06-11 09:07:06 +00:00 (Migrated from github.com)
Copy Link

@lunny ping

@lunny ping
lunny commented 2019-06-11 15:59:32 +00:00
Copy Link

@mskrip will do last review tomorrow morning.

@mskrip will do last review tomorrow morning.
mskrip commented 2019-06-21 08:47:28 +00:00 (Migrated from github.com)
Copy Link

@lunny Okay, thank you

@lunny Okay, thank you
lunny commented 2019-06-23 02:44:56 +00:00
Copy Link

@mskrip Thanks!

@mskrip Thanks!
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backport/done

   
backport/v1

   
blocked
  
db
oracle

  
db
sqlserver

  
duplicate
  
feature
cache

  
frontport/done

   
frontport/main

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependencies

  
kind
docs

  
kind
driver

  
kind
enhancement

  
kind
feature

  
kind
performance

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
testing

  
need
feedback

  
need
test

  
proposal:accepted

   
RaspBerry Pi

   
regression

   
skip-changelog

   
upstream

   
wip

   
wontfix
No Label
backport/done
backport/v1
blocked
db
oracle
db
sqlserver
duplicate
feature
cache
frontport/done
frontport/main
invalid
kind
breaking
kind
bug
kind
build
kind
dependencies
kind
docs
kind
driver
kind
enhancement
kind
feature
kind
performance
kind
proposal
kind
question
kind
refactor
kind
testing
need
feedback
need
test
proposal:accepted
RaspBerry Pi
regression
skip-changelog
upstream
wip
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#1284
No description provided.
Delete Branch "same-type-extends"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?