Oracle bracket quote is breaking queries #1507

Closed
opened 2020-01-08 16:15:17 +00:00 by jama707 · 2 comments

It was mentioned here as well #1434 (comment) but I was unable to comment.

Just removing brackets in Quote method is fixing the issue:

func (db *oracle) Quote(name string) string {
	return name
}

https://gitea.com/xorm/xorm/src/branch/master/dialect_oracle.go#L554

Is this a known issue? any progress?

It was mentioned here as well https://gitea.com/xorm/xorm/issues/1434#issue-18712 but I was unable to comment. Just removing brackets in `Quote` method is fixing the issue: ``` func (db *oracle) Quote(name string) string { return name } ``` https://gitea.com/xorm/xorm/src/branch/master/dialect_oracle.go#L554 Is this a known issue? any progress?
Owner

This is a know issue, it depends on #1435 .

This is a know issue, it depends on #1435 .
lunny added the
kind
bug
label 2020-01-09 08:40:02 +00:00
Owner

will be closed by #1567

will be closed by #1567
lunny added this to the 1.0.0 milestone 2020-03-03 13:19:52 +00:00
lunny closed this issue 2020-03-06 07:49:30 +00:00
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#1507
No description provided.