feature 'deleted' not work properly with join? #1512

New Issue

sesky42 · 2020-01-17T09:45:23Z

sesky42 commented

2020-01-17 09:45:23 +00:00

type User struct{
	Id		 int
	DeleteAt time.Time `xorm:"deleted"`
}

type Group struct{
	Id int
}

type UserGroup struct{
	User	`xorm:"extends"`
    Group	`xorm:"extends"`
}

func (ug UserGroup) TableName() string{
	return "group" // it cause xorm generate sql like SELECT ...WHERE `group`.`delete_at` IS NOT NULL....
}

Because

func (table *Table) DeletedColumn() *Column {
	return table.GetColumn(table.Deleted)
}

I don't know whether it should be a bug or not.
But it really confused me for sometime.

``` type User struct{ Id int DeleteAt time.Time `xorm:"deleted"` } type Group struct{ Id int } type UserGroup struct{ User `xorm:"extends"` Group `xorm:"extends"` } func (ug UserGroup) TableName() string{ return "group" // it cause xorm generate sql like SELECT ...WHERE `group`.`delete_at` IS NOT NULL.... } ``` Because ``` func (table *Table) DeletedColumn() *Column { return table.GetColumn(table.Deleted) } ``` I don't know whether it should be a bug or not. But it really confused me for sometime.

lunny commented

2020-01-17 12:02:28 +00:00

When you use extends all parent structs' fields wil be considered as current table's columns.

When you use `extends` all parent structs' fields wil be considered as current table's columns.

lunny added the

need

feedback

label 2020-01-20 15:43:52 +00:00

lunny added

kind

bug

and removed