FindAndCount 生成的SQL语句会多判断一次 deleted #1617

New Issue

kisesy · 2020-03-23T09:02:33Z

kisesy commented

2020-03-23 09:02:33 +00:00

重复 #1398 因为原帖无法回复，所以重开一个

比如:

type Comment struct {
	Id        int               `xorm:"pk autoincr"`
	DeletedAt int64             `xorm:"deleted notnull default(0) index"`
}

var comments []Comment
x.FindAndCount(&comments)

[xorm] [info]  2020/03/23 16:53:00.492750 [SQL] SELECT count(*) FROM `comment` WHERE deleted_at=? AND deleted_at=? [0 0] - 999.4µs

deleted_at=? AND deleted_at=? 重复判断，如果单独使用 Find 就是一个判断

重复 https://gitea.com/xorm/xorm/issues/1398 因为原帖无法回复，所以重开一个比如: ```go type Comment struct { Id int `xorm:"pk autoincr"` DeletedAt int64 `xorm:"deleted notnull default(0) index"` } var comments []Comment x.FindAndCount(&comments) ``` ```sql [xorm] [info] 2020/03/23 16:53:00.492750 [SQL] SELECT count(*) FROM `comment` WHERE deleted_at=? AND deleted_at=? [0 0] - 999.4µs ``` deleted_at=? AND deleted_at=? 重复判断，如果单独使用 Find 就是一个判断

lunny added the

kind

bug

label 2020-03-23 12:45:44 +00:00

lunny referenced a pull request that will close this issue

2020-03-23 12:46:04 +00:00

Fix duplicated deleted condition on FindAndCount #1619

lunny added this to the 1.0.1 milestone 2020-03-23 12:54:21 +00:00

kisesy commented

2020-03-23 14:07:13 +00:00

这个我测试也可以了

lunny closed this issue