xorm/xorm
xorm/xorm
63
355
Fork 204
Code Issues 368 Pull Requests 16 Actions Releases 35 Activity

chore: improve titleCasedName performance #1691

Merged
lunny merged 2 commits from performance into master 2020-05-23 02:24:10 +00:00
Conversation 1 Commits 2 Files Changed 2 +18 -7
appleboy commented 2020-05-22 04:53:15 +00:00
Member
Copy Link
$ go test -bench="TitleCasedName" ./names/...
goos: darwin
goarch: amd64
pkg: xorm.io/xorm/names
BenchmarkTitleCasedNameOld-4      376286              3272 ns/op            2248 B/op          9 allocs/op
BenchmarkTitleCasedNameNew-4     1567888               763 ns/op             224 B/op          1 allocs/op
PASS
ok      xorm.io/xorm/names      5.394s

Signed-off-by: Bo-Yi Wu appleboy.tw@gmail.com

``` $ go test -bench="TitleCasedName" ./names/... goos: darwin goarch: amd64 pkg: xorm.io/xorm/names BenchmarkTitleCasedNameOld-4 376286 3272 ns/op 2248 B/op 9 allocs/op BenchmarkTitleCasedNameNew-4 1567888 763 ns/op 224 B/op 1 allocs/op PASS ok xorm.io/xorm/names 5.394s ``` Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
appleboy added 1 commit 2020-05-22 04:53:19 +00:00
chore: improve titleCasedName performance 
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
1360686907
appleboy reviewed 2020-05-22 07:29:21 +00:00
Dismissed
names/mapper.go Outdated
@ -115,2 +116,2 @@
if 'a' <= chr && chr <= 'z' {
chr -= ('a' - 'A')
if 'a' <= c && c <= 'z' {
c += 'a' - 'A'
appleboy commented 2020-05-22 07:29:21 +00:00
Author
Member
Copy Link

I will change to c -= 'a' - 'A'

I will change to `c -= 'a' - 'A'`
appleboy added 1 commit 2020-05-22 07:30:13 +00:00
udpate 
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Some checks reported errors
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build encountered an error
Details
1637507361
appleboy commented 2020-05-23 00:39:38 +00:00
Author
Member
Copy Link

something wrong with goproxy in China. https://drone.gitea.com/xorm/xorm/1081/1/12

something wrong with goproxy in China. https://drone.gitea.com/xorm/xorm/1081/1/12
lunny merged commit f071e5eb96 into master 2020-05-23 02:22:15 +00:00
lunny added the
kind
performance
 label 2020-05-23 02:22:31 +00:00
appleboy added this to the 1.1.1 milestone 2020-05-23 17:12:19 +00:00
lunny modified the milestone from 1.1.1 to 1.0.2 2020-06-13 03:14:56 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backport/done

   
backport/v1

   
blocked
  
db
oracle

  
db
sqlserver

  
duplicate
  
feature
cache

  
frontport/done

   
frontport/main

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependencies

  
kind
docs

  
kind
driver

  
kind
enhancement

  
kind
feature

  
kind
performance

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
testing

  
need
feedback

  
need
test

  
proposal:accepted

   
RaspBerry Pi

   
regression

   
skip-changelog

   
upstream

   
wip

   
wontfix
No Label
backport/done
backport/v1
blocked
db
oracle
db
sqlserver
duplicate
feature
cache
frontport/done
frontport/main
invalid
kind
breaking
kind
bug
kind
build
kind
dependencies
kind
docs
kind
driver
kind
enhancement
kind
feature
kind
performance
kind
proposal
kind
question
kind
refactor
kind
testing
need
feedback
need
test
proposal:accepted
RaspBerry Pi
regression
skip-changelog
upstream
wip
wontfix
Milestone
Clear milestone
No items
No Milestone
1.0.2
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#1691
No description provided.
Delete Branch "performance"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?