使用 logrus 作为 contextLogger 时，engine 优先当做 log.Logger 处理了 #1728

New Issue

KowloonZh · 2020-06-29T03:03:06Z

KowloonZh commented

2020-06-29 03:03:06 +00:00

// SetLogger set the new logger
func (engine *Engine) SetLogger(logger interface{}) {
	var realLogger log.ContextLogger
	switch t := logger.(type) {
	case log.Logger:
		realLogger = log.NewLoggerAdapter(t)
	case log.ContextLogger:
		realLogger = t
	}
	engine.logger = realLogger
	engine.DB().Logger = realLogger
}

期望：在 case 里面优先判断 log.ContextLogger

``` // SetLogger set the new logger func (engine *Engine) SetLogger(logger interface{}) { var realLogger log.ContextLogger switch t := logger.(type) { case log.Logger: realLogger = log.NewLoggerAdapter(t) case log.ContextLogger: realLogger = t } engine.logger = realLogger engine.DB().Logger = realLogger } ``` 期望：在 case 里面优先判断 log.ContextLogger

lunny commented

2020-06-29 03:03:41 +00:00

Could you send a PR?

KowloonZh commented

2020-06-29 03:09:17 +00:00

Could you send a PR?

我试试哈，没玩过 gitea

> Could you send a PR? 我试试哈，没玩过 gitea

KowloonZh commented

2020-06-29 03:16:26 +00:00

Could you send a PR?

已提交，如果操作有不规范的地方，辛苦指出来一下

#1729/commits

> Could you send a PR? 已提交，如果操作有不规范的地方，辛苦指出来一下 https://gitea.com/xorm/xorm/pulls/1729/commits

lunny commented

2021-06-12 09:56:39 +00:00

This has been resovled.

lunny closed this issue

2021-06-12 09:56:39 +00:00

Sign in to join this conversation.

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#1728