session.innerInsertMulti(bean) 是否可以支持map[string]interface{} 类型的批量插入？现在的批量插入效率低了一些。 #1767

New Issue

gepeng · 2020-08-23T01:02:43Z

gepeng commented

2020-08-23 01:02:43 +00:00

func (session *Session) Insert(beans ...interface{}) (int64, error) {
...
for _, bean := range beans {
switch bean.(type) {
case map[string]interface{}:
...
case []map[string]interface{}:
s := bean.([]map[string]interface{})
for i := 0; i < len(s); i++ {
cnt, err := session.insertMapInterface(s[i])
if err != nil {
return affected, err
}
affected += cnt
....
}

func (session *Session) Insert(beans ...interface{}) (int64, error) { ... for _, bean := range beans { switch bean.(type) { case map[string]interface{}: ... case []map[string]interface{}: s := bean.([]map[string]interface{}) **for i := 0; i < len(s); i++ { cnt, err := session.insertMapInterface(s[i]) if err != nil { return affected, err }** affected += cnt .... }

lunny commented

2020-08-23 02:30:38 +00:00

A map[string]interface{} means one record?

A `map[string]interface{}` means one record?

gepeng commented

2020-08-23 03:32:34 +00:00

// Like codes followed. Beans may be a big array

func importer(x *xorm.Engine, tableName string, beans []map[string]interface{}) error {
_, err:= x.Table(tableName).Insert(beans)
return err
}

// Like codes followed. Beans may be a big array func importer(x *xorm.Engine, tableName string, beans []map[string]interface{}) error { _, err:= x.Table(tableName).Insert(beans) return err }

gepeng commented

2020-08-23 03:38:34 +00:00

如果是mysql，inser(beans []map[string]interface) 会生成多个"insert into table (fields...) values(?,?,...)"。 inert([]struct{...}) 生成的是insert into table (fields...) values(?,?,?...),(?,?,?...),...。效率会有数量级差别。

lunny added the

kind

enhancement

label 2020-08-23 06:15:39 +00:00

lunny added this to the 1.0.4 milestone 2020-08-23 06:15:54 +00:00

lunny modified the milestone from 1.0.4 to 1.0.5

2020-08-31 01:21:52 +00:00

lunny modified the milestone from 1.0.5 to 1.0.6

2020-09-08 13:57:08 +00:00

lunny modified the milestone from 1.0.6 to 1.1.1

2020-11-03 07:31:07 +00:00

lunny modified the milestone from 1.1.1 to 1.3.0