sqlite escapes wrongly if you need all columns from specific table #1780

New Issue

lafriks · 2020-09-04T14:48:00Z

lafriks commented

2020-09-04 14:48:00 +00:00

If you specify:

  .Cols("`table1`.*, `table2`.id")

xorm would generate select for sqlite:

SELECT `table1`.`*`, `table2`.`id` FROM ...

that is invalid SQL. Correct would be:

SELECT `table1`.*, `table2`.`id` FROM ...

If you specify: ```go .Cols("`table1`.*, `table2`.id") ``` xorm would generate select for sqlite: ```sql SELECT `table1`.`*`, `table2`.`id` FROM ... ``` that is invalid SQL. Correct would be: ```sql SELECT `table1`.*, `table2`.`id` FROM ... ```

lafriks added the

kind

bug

label 2020-09-04 14:48:29 +00:00

lafriks added

invalid

and removed

kind

bug

labels 2020-09-04 15:01:06 +00:00

lafriks commented

2020-09-04 15:01:30 +00:00

Can not reproduce it anymore. Looks like in latest it is already fixed

lafriks added

kind

bug

and removed

invalid

labels 2020-09-04 15:05:56 +00:00

lafriks commented

2020-09-04 15:06:09 +00:00

Sry, managed to reproduce :)

lafriks referenced a pull request that will close this issue

2020-09-04 15:20:32 +00:00

Do not ever quote asterisk symbol. Fixes #1780 #1781

lunny added this to the 1.0.5 milestone 2020-09-05 11:49:35 +00:00

lunny referenced this issue from a commit

2020-09-06 08:22:39 +00:00

Do not ever quote asterisk symbol. Fixes #1780 (#1781)

lunny closed this issue

2020-09-06 08:22:39 +00:00

Sign in to join this conversation.

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#1780