Session.Table().ID().Exist does not meet expectations #1818

New Issue

Epsirom · 2020-10-29T03:20:13Z

Epsirom commented

2020-10-29 03:20:13 +00:00

The following three demos should have the same result and SQL, but in fact they are different with xorm.io/xorm v1.0.5

engine, _ := xorm.NewEngine(...)
has, err := engine.ID(123).Cols("id").Exist(new(Table))
fmt.Println(has, err) // false nil
// engine.ShowSQL() will output: SELECT `id` FROM `table` WHERE `id`=? LIMIT 1 [123]

engine, _ := xorm.NewEngine(...)
has, err := engine.Table(new(Table)).ID(123).Cols("id").Exist()
fmt.Println(has, err) // true nil
// engine.ShowSQL() will output: SELECT * FROM `table`  LIMIT 1 []

engine, _ := xorm.NewEngine(...)
has, err := engine.Table(new(Table)).Where("id = ?", 123).Cols("id").Exist()
fmt.Println(has, err) // false nil
// engine.ShowSQL() will output: SELECT * FROM `table`  WHERE (id = ?) LIMIT 1 [123]

The first demo is the ground truth, and the third demo is acceptable(Cols("id") is ignored but does not affect the result).

The following three demos should have the same result and SQL, but in fact they are different with xorm.io/xorm v1.0.5 ```golang engine, _ := xorm.NewEngine(...) has, err := engine.ID(123).Cols("id").Exist(new(Table)) fmt.Println(has, err) // false nil // engine.ShowSQL() will output: SELECT `id` FROM `table` WHERE `id`=? LIMIT 1 [123] ``` ```golang engine, _ := xorm.NewEngine(...) has, err := engine.Table(new(Table)).ID(123).Cols("id").Exist() fmt.Println(has, err) // true nil // engine.ShowSQL() will output: SELECT * FROM `table` LIMIT 1 [] ``` ```golang engine, _ := xorm.NewEngine(...) has, err := engine.Table(new(Table)).Where("id = ?", 123).Cols("id").Exist() fmt.Println(has, err) // false nil // engine.ShowSQL() will output: SELECT * FROM `table` WHERE (id = ?) LIMIT 1 [123] ``` The first demo is the ground truth, and the third demo is acceptable(Cols("id") is ignored but does not affect the result).

lunny added the

kind

bug

label 2020-10-29 06:43:34 +00:00

lunny added this to the 1.1.1 milestone 2021-06-06 13:07:07 +00:00

lunny referenced a pull request that will close this issue

2021-06-06 13:13:58 +00:00

Fix exist #1921

lunny referenced this issue from a commit

2021-06-07 05:45:30 +00:00

Fix exist (#1921)

lunny closed this issue