prevent panic when struct with unexport field #1839

Merged
lunny merged 4 commits from :fix_panic_with_unexport_fields into master 2020-12-02 14:07:45 +00:00
Contributor

when using vanila protobuf generated struct (eg, without xorm struct tags) for xorm input, the unexported filed will cause panic, this pull request fix the panic, also making xorm functions ignoring unexport field without xorm tag though.
ps.thanks for your nice work.

when using vanila protobuf generated struct (eg, without xorm struct tags) for xorm input, the unexported filed will cause panic, this pull request fix the panic, also making xorm functions ignoring unexport field without xorm tag though. ps.thanks for your nice work.
finelog added 1 commit 2020-12-02 13:07:27 +00:00
Some checks reported errors
continuous-integration/drone/pr Build was killed
a6b65d30c7
prevent panic when struct with unexport field
finelog started working 2020-12-02 13:14:00 +00:00
finelog canceled time tracking 2020-12-02 13:14:04 +00:00
First-time contributor

looks fine as in this case we don't need to use additional protoc plugin to tag unexported fields via xorm:"-"

looks fine as in this case we don't need to use additional protoc plugin to tag unexported fields via xorm:"-"
Owner

@finelog Could you add some test?

@finelog Could you add some test?
Author
Contributor

@finelog Could you add some test?

ok, I'll try

> @finelog Could you add some test? ok, I'll try
finelog added 1 commit 2020-12-02 13:47:11 +00:00
Some checks reported errors
continuous-integration/drone/pr Build was killed
dfe9f387cf
add test for prevent panic when vanial struct with unexport field panic
Author
Contributor

@finelog Could you add some test?

@lunny I have add test for my pr, please check it out. thanks!

> @finelog Could you add some test? @lunny I have add test for my pr, please check it out. thanks!
finelog added 1 commit 2020-12-02 13:53:25 +00:00
Some checks reported errors
continuous-integration/drone/pr Build was killed
4538725949
minor code fix
finelog added 1 commit 2020-12-02 13:54:46 +00:00
Some checks reported errors
continuous-integration/drone/pr Build encountered an error
55e7f68a77
minor fix part II
lunny approved these changes 2020-12-02 14:07:30 +00:00
Dismissed
lunny merged commit 3472d80a6d into master 2020-12-02 14:07:36 +00:00
Owner
@finelog @vtolstov Thanks!
lunny added this to the 1.0.6 milestone 2020-12-02 14:08:19 +00:00
lunny added the
kind
enhancement
label 2020-12-02 14:08:30 +00:00
Author
Contributor

it's pleasure. again, thanks for your work. really help us a lot.

it's pleasure. again, thanks for your work. really help us a lot.
Sign in to join this conversation.
No description provided.