xorm can't handle nil return values #1844

New Issue

kolaente · 2020-12-23T13:58:32Z

kolaente commented

2020-12-23 13:58:32 +00:00

I have a function like this one:

func GetListByID(s *xorm.Session, listID int64) (list *List, err error) {
	_, err = s.Where("id = ?", listID).Get(list)
	return
}

Calling it fails with a Table not found error.

I looked into it and it seems like the table name is not set and thus the error is returned.

However, when I initialize the struct like this, it works:

func GetListByID(s *xorm.Session, listID int64) (list *List, err error) {
	list = &List{}
	_, err = s.Where("id = ?", listID).Get(list)
	return
}

Is that a bug or a limitation in go?

I have a function like this one: ```go func GetListByID(s *xorm.Session, listID int64) (list *List, err error) { _, err = s.Where("id = ?", listID).Get(list) return } ``` Calling it fails with a `Table not found` error. I looked into it and it seems like the table name is not set and thus the error is returned. However, when I initialize the struct like this, it works: ```go func GetListByID(s *xorm.Session, listID int64) (list *List, err error) { list = &List{} _, err = s.Where("id = ?", listID).Get(list) return } ``` Is that a bug or a limitation in go?

lunny commented

2020-12-23 15:49:47 +00:00

@kolaente I think it's a limitation of xorm. XORM always assume that the parameter of Get is a not an empty pointer.

@kolaente I think it's a limitation of xorm. XORM always assume that the parameter of `Get` is a not an empty pointer.

kolaente commented

2020-12-24 01:10:56 +00:00

Do you know if there is a way for xorm to check if that's really the case? I think it would be useful to throw an error in that case - it took me a while to find the cause of the issue.