delete 删除存着bug，配置offset的偏移不生效 #1894

New Issue

DemoLiang · 2021-04-12T03:53:48Z

DemoLiang commented

2021-04-12 03:53:48 +00:00

测试语句：使用limit配置删除的limit限制，offset偏移
DB["abcd"].Table(tht(tableId)).Where(where, args...).
OrderBy("result_id asc").Limit(limit, offset).Delete(new(TaskHost))

最后生成的语句：
DELETE FROM task WHERE (host=? and id = ?) ORDER BY result_id asc LIMIT 100 []interface {}{"10.10.110.110", 111}

正常我们删除数据应该可以根据偏移，第offset之后的所有的所有数据

测试语句：使用limit配置删除的limit限制，offset偏移 DB["abcd"].Table(tht(tableId)).Where(where, args...). OrderBy("result_id asc").Limit(limit, offset).Delete(new(TaskHost)) 最后生成的语句： DELETE FROM `task` WHERE (host=? and id = ?) ORDER BY result_id asc LIMIT 100 []interface {}{"10.10.110.110", 111} 正常我们删除数据应该可以根据偏移，第offset之后的所有的所有数据

lunny added the

kind

bug

label 2021-04-12 04:58:45 +00:00

lunny added this to the 1.1.1 milestone 2021-04-12 04:58:48 +00:00

lunny referenced a pull request that will close this issue

2021-04-12 05:09:48 +00:00

Delete Limit with start will return error because it's not supported by database #1895

lunny commented

2021-04-12 05:10:59 +00:00

Which database are you using? I don't think database support the SQL syntax. I sent #1895 to return an error.

DemoLiang commented

2021-04-12 07:56:45 +00:00

Which database are you using? I don't think database support the SQL syntax. I sent #1895 to return an error.

确实，不允许。
我开始写orm 查询语句的时候看着可以这么传入，以为可以这么干，我后面查了下好像不能运行这样的offset，可以单独加limit
我开始以为挺正常的一个操作，没注意mysql不允许这么干的，翻车现场了

> Which database are you using? I don't think database support the SQL syntax. I sent #1895 to return an error. 确实，不允许。我开始写orm 查询语句的时候看着可以这么传入，以为可以这么干，我后面查了下好像不能运行这样的offset，可以单独加limit 我开始以为挺正常的一个操作，没注意mysql不允许这么干的，翻车现场了

lunny removed the

kind

bug

label 2021-06-07 08:23:00 +00:00

lunny removed this from the 1.1.1 milestone 2021-06-07 08:23:04 +00:00

lunny closed this issue

2021-06-07 08:23:08 +00:00

lunny referenced this issue from a commit

2023-07-26 06:58:57 +00:00

Delete Limit with start will return error because it's not supported by database (#1895)

Sign in to join this conversation.