Ignore comments when deciding when to replace question marks. #1954 #1955

antialiasis · 2021-06-14T16:16:51Z

antialiasis commented

2021-06-14 16:16:51 +00:00

This should solve #1954 and adds some tests for it. I will note I'm not 100% clear on whether there are other edge cases that should be covered here. From what I understand the only standard SQL way to escape single quotes is to double them, which shouldn't cause any problems with this, but if some SQL flavors allow other kinds of escaping, for instance, that would probably need to be covered too for ideal results.

antialiasis added 1 commit 2021-06-14 16:16:52 +00:00

Ignore comments when deciding when to replace quetion marks.

continuous-integration/drone/pr Build is failing

Details

898e7b6fb5

antialiasis changed title from ~~Ignore comments when deciding when to replace quetion marks. #1954~~ to Ignore comments when deciding when to replace question marks. #1954

2021-06-14 16:39:52 +00:00

antialiasis commented

2021-06-15 12:31:57 +00:00

I don't know or use MSSQL and am not sure how this update could be causing the supposed race condition that's coming up in the CI tests (at least if it didn't exist before). I can't do further tests on it either without installing and configuring it on my system from scratch for this sole purpose. If someone else knows what's going on there, a pointer or fix would be much appreciated.

lunny commented

2021-06-15 12:34:34 +00:00

I don't know or use MSSQL and am not sure how this update could be causing the supposed race condition that's coming up in the CI tests (at least if it didn't exist before). I can't do further tests on it either without installing and configuring it on my system from scratch for this sole purpose. If someone else knows what's going on there, a pointer or fix would be much appreciated.

It should be a bug of mssql driver and not related with this PR.

> I don't know or use MSSQL and am not sure how this update could be causing the supposed race condition that's coming up in the CI tests (at least if it didn't exist before). I can't do further tests on it either without installing and configuring it on my system from scratch for this sole purpose. If someone else knows what's going on there, a pointer or fix would be much appreciated. It should be a bug of mssql driver and not related with this PR.

lunny added 1 commit 2021-06-15 15:51:39 +00:00

Merge branch 'master' into issue-1954

continuous-integration/drone/pr Build is passing

Details

180bd9a5a3

lunny approved these changes 2021-06-26 11:18:56 +00:00

lunny added the

kind

bug

label 2021-06-26 11:19:09 +00:00

lunny merged commit 44f892fddc into master

2021-06-26 11:19:14 +00:00