this method may cause caller does not get all the rows, but the truth is due to error occurred, and there's no way for caller to detect error #1992
Labels
No Label
backport/done
backport/v1
blocked
db
oracle
db
sqlserver
duplicate
feature
cache
frontport/done
frontport/main
invalid
kind
breaking
kind
bug
kind
build
kind
dependencies
kind
docs
kind
driver
kind
enhancement
kind
feature
kind
performance
kind
proposal
kind
question
kind
refactor
kind
testing
need
feedback
need
test
proposal:accepted
RaspBerry Pi
regression
skip-changelog
upstream
wip
wontfix
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: xorm/xorm#1992
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
779a74ccff/session_find.go (L252)
In the source code from golang, any error during calling the Next method is depressed, after calling Next if got false, should call rows.Err() to detect if error orrurred.
// Every call to Scan, even the first one, must be preceded by a call to Next.
func (rs *Rows) Next() bool {
var doClose, ok bool
withLock(rs.closemu.RLocker(), func() {
doClose, ok = rs.nextLocked()
})
if doClose {
rs.Close()
}
return ok
}
这里可能会因为连接被server端断开,导致并未读取所有的行to this method may cause caller does not get all the rows, but the truth is due to error occurred, and there's no way for caller to detect errorHi, could you send a PR to resolve the problem?
Thanks so much for your reply, I've just initialized a PR for this issue, by any chance help to check.