Support for whitespace in Postgres connection opts #2010

New Issue

wbrowne · 2021-07-26T11:00:31Z

wbrowne commented

2021-07-26 11:00:31 +00:00

The following inputs to the dialets.TestParsePostgres test are not supported and thus fail:

{"user='auser' password='password' dbname='db' sslmode='disable'", "db", true},
{"user='a user' password = 'password' dbname='db' sslmode='disable'", "db", true},

Given the documentation from PostgreSQL, shouldn't they be supported?

In the keyword/value format, each parameter setting is in the form keyword = value, with space(s) between settings. Spaces around a setting's equal sign are optional. To write an empty value, or a value containing spaces, surround it with single quotes, for example keyword = 'a value'. Single quotes and backslashes within a value must be escaped with a backslash, i.e., ' and \.

Example:
host=localhost port=5432 dbname=mydb connect_timeout=10

Is there any other possible way to support creating a Postgres connection using opts for a user containing whitespace?

IE

host=localhost port=5432 dbname=mydb connect_timeout=10 user='test user'

The following inputs to the `dialets.TestParsePostgres` test are not supported and thus fail: ``` {"user='auser' password='password' dbname='db' sslmode='disable'", "db", true}, {"user='a user' password = 'password' dbname='db' sslmode='disable'", "db", true}, ``` Given the [documentation from PostgreSQL](https://www.postgresql.org/docs/10/libpq-connect.html#LIBPQ-CONNSTRING), shouldn't they be supported? >In the keyword/value format, each parameter setting is in the form keyword = value, with space(s) between settings. Spaces around a setting's equal sign are optional. To write an empty value, or a value containing spaces, surround it with single quotes, for example keyword = 'a value'. Single quotes and backslashes within a value must be escaped with a backslash, i.e., \' and \\. > >Example: > >``` >host=localhost port=5432 dbname=mydb connect_timeout=10 >``` Is there any other possible way to support creating a Postgres connection *using opts* for a user containing whitespace? IE `host=localhost port=5432 dbname=mydb connect_timeout=10 user='test user'`

lunny commented

2021-07-26 13:30:06 +00:00

You can also use postgres://pqgotest:password@localhost/pqgotest?sslmode=verify-full

You can also use `postgres://pqgotest:password@localhost/pqgotest?sslmode=verify-full`

lunny added the

kind

question

label 2021-07-26 13:30:14 +00:00

wbrowne commented

2021-07-26 15:29:18 +00:00

@lunny is there any way to achieve this without using the URI option? I would still like to use the keyword/value format

@lunny is there any way to achieve this without using the URI option? I would still like to use the `keyword/value` format

lunny referenced a pull request that will close this issue

2021-07-27 16:19:12 +00:00

Fix postgres driver datasource name parse #2012

lunny commented

2021-07-27 16:19:32 +00:00

Please confirm that #2012 fix this problem.

{"user='a user' password = 'password' dbname='db' sslmode='disable'", "db", true}, will not be supported, key should not have space followed before equal.
It should be {"user='a user' password='password' dbname='db' sslmode='disable'", "db", true},

Please confirm that #2012 fix this problem. `{"user='a user' password = 'password' dbname='db' sslmode='disable'", "db", true},` will not be supported, key should not have space followed before equal. It should be `{"user='a user' password='password' dbname='db' sslmode='disable'", "db", true},`

lunny referenced this issue from a commit

2021-07-28 02:03:09 +00:00

Fix postgres driver datasource name parse (#2012)

lunny closed this issue

2021-07-28 02:03:09 +00:00

lunny closed this issue

2021-07-28 02:03:10 +00:00

Sign in to join this conversation.