Fix to add session.statement.IsForUpdate check in Session.queryRows() #2064

Merged
lunny merged 4 commits from rennnosuke/xorm:fix/exec_for_update_on_master into master 2021-11-24 02:29:40 +00:00
Contributor

Issue

The 'for-update' query is executed to slave DB node.

Example

s := engineGroup.NewSession(); // create session from EngineGroup.
...

s.ForUpdate();

type User struct { ... };
var user User;
has, err := s.Get(&user); // executed to slave DB node.
...
# Issue The 'for-update' query is executed to slave DB node. # Example ```go s := engineGroup.NewSession(); // create session from EngineGroup. ... s.ForUpdate(); type User struct { ... }; var user User; has, err := s.Get(&user); // executed to slave DB node. ... ```
rennnosuke added 1 commit 2021-10-28 08:41:26 +00:00
Some checks failed
continuous-integration/drone/pr Build is failing
e03ecdfeee
fix to add session.statement.IsForUpdate check in Session.queryRows()
# Issue
The 'for-update' query is executed to slave DB node.  


# Example

```go
s := engineGroup.NewSession(); // create session from EngineGroup.
...

s.ForUpdate();

type User struct { ... };
has, err := s.Get(&user); // executed to slave DB node.
...
```
lunny approved these changes 2021-10-28 08:51:29 +00:00
lunny added this to the 1.3.0 milestone 2021-10-28 08:51:37 +00:00
lunny added the
kind
enhancement
label 2021-10-28 08:51:45 +00:00
Owner

Please resolve the conflict.

Please resolve the conflict.
rennnosuke added 1 commit 2021-10-29 08:16:30 +00:00
Some checks failed
continuous-integration/drone/pr Build is failing
3996bd66ed
Merge branch 'master' into fix/exec_for_update_on_master
lunny added 1 commit 2021-10-29 09:31:33 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
fe90482327
Merge branch 'master' into fix/exec_for_update_on_master
Author
Contributor

@lunny
It seems that some CI steps are failing due to OOM. Could you retry to run those steps or confirm the CI configuration?

@lunny It seems that some CI steps are failing due to OOM. Could you retry to run those steps or confirm the CI configuration?
rennnosuke added 1 commit 2021-11-23 09:03:27 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
3ecf64a7e8
Merge branch 'master' into fix/exec_for_update_on_master
lunny merged commit 885f582677 into master 2021-11-24 02:29:40 +00:00
Sign in to join this conversation.
No description provided.