Escape string and blob results from dump more correctly #2091
No reviewers
Labels
No Label
backport/done
backport/v1
blocked
db
oracle
db
sqlserver
duplicate
feature
cache
frontport/done
frontport/main
invalid
kind
breaking
kind
bug
kind
build
kind
dependencies
kind
docs
kind
driver
kind
enhancement
kind
feature
kind
performance
kind
proposal
kind
question
kind
refactor
kind
testing
need
feedback
need
test
proposal:accepted
RaspBerry Pi
regression
skip-changelog
upstream
wip
wontfix
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: xorm/xorm#2091
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "zeripath/xorm:escape-results-from-dump"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
dumpTables currently badly handles BLOB and TEXT data containing control
characters:
MySQL will interpret and unescape string literals e.g.
\r
will becomecarriage return.
Postgres will not allow string literals to contain NUL nor will
SQLite so BLOBs will not dump correctly.
Schemas should not be set on the destination dump
MSSQL needs the N prefix to correctly ensure that UTF-8 data is
correctly transferred.
Signed-off-by: Andrew Thornton art27@cantab.net
I need to go through MSSQL and the other non-Gitea enabled DB types to check that blobs and control characters are being properly handled there too.
OK, so I think I've got this working now.
However, large blobs and large text fields will not be being handled correctly.
COPY
and an escaped format of its own designbut I dunno