对于json字段,希望能由使用者自己指定DefaultJSONHandler #2129
Labels
No Label
backport/done
backport/v1
blocked
db
oracle
db
sqlserver
duplicate
feature
cache
frontport/done
frontport/main
invalid
kind
breaking
kind
bug
kind
build
kind
dependencies
kind
docs
kind
driver
kind
enhancement
kind
feature
kind
performance
kind
proposal
kind
question
kind
refactor
kind
testing
need
feedback
need
test
proposal:accepted
RaspBerry Pi
regression
skip-changelog
upstream
wip
wontfix
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: xorm/xorm#2129
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
目前的DefaultJSONHandler位于internal/json/json.go文件中
由于该文件位于internal路径下,所以外部无法访问和更换DefaultJSONHandler,是否提供接口由外部指定呢?
我看到那文件底下还有jsoniter.go、gojson.go等其他json库的接口文件,由// +build编译标记来控制,但这不是我想要的,我想用我自己的JSONHandler,不想用默认的
已经过去很久了,没消息了吗?
现在jsoniter已经不是性能最好的了,据说https://github.com/bytedance/sonic 性能更好
json库性能严重影响了xorm库性能,我感觉xorm没必要疲于引进最强的json库,把这个选择提供给用户就行了
新增一个SetDefaultJSONHandler方法就行
我对提交合并请求的流程不熟悉,不然我就去提交了
Please send a PR.
我晚上试试
刚刚提交了合并请求
见#2242