PostgreSQL: enable comment on column #2131

Merged
lunny merged 4 commits from pilou/xorm:postgresql_handle_column_comment into master 2022-04-17 10:03:30 +00:00
Contributor

The oldest unsupported version documentation states that comment on a column is supported.

Update TestGetColumnsComment in order to check both MySQL/MariaDB and PostgreSQL.

The [oldest unsupported version documentation](https://www.postgresql.org/docs/7.1/sql-comment.html) states that comment on a column is supported. Update `TestGetColumnsComment` in order to check both MySQL/MariaDB and PostgreSQL.
pilou added 2 commits 2022-04-13 02:49:04 +00:00
pilou force-pushed postgresql_handle_column_comment from 302faa87dd to e100edad4b 2022-04-13 18:15:06 +00:00 Compare
lunny approved these changes 2022-04-16 02:30:32 +00:00
lunny added this to the 1.3.1 milestone 2022-04-16 02:30:48 +00:00
lunny added the
kind
enhancement
label 2022-04-16 02:31:04 +00:00
lunny added 1 commit 2022-04-16 02:31:32 +00:00
Some checks failed
continuous-integration/drone/pr Build is failing
3da4fc74a3
Merge branch 'master' into postgresql_handle_column_comment
Author
Contributor

mssql test fails:

db.Exec: lookup mssql on 127.0.0.11:53: no such host
FAIL	xorm.io/xorm/integrations	0.124s
FAIL
make: *** [Makefile:151: test-mssql] Error 1

I locally tested this branch successfully using mssql:

$ git rev-parse HEAD
3da4fc74a30596ad6442aeeddd09a86aacf8f9a6
$ docker run -e "ACCEPT_EULA=Y" -e "SA_PASSWORD=X@rmX@rm" -e MSSQL_PID=Standard -p 1433:1433 -d mcr.microsoft.com/mssql/server:latest
4df2224ba61c4716a163e463c475cf85b496b801e08662aa1b9c26ff7ea1f02b
$ docker inspect 4df2224ba61c4716a163e463c475cf85b496b801e08662aa1b9c26ff7ea1f02b -f "{{ .NetworkSettings.Networks.bridge.IPAddress }}"
172.18.0.4
$ TEST_MSSQL_HOST=172.18.0.4 TEST_MSSQL_DBNAME=xorm_test TEST_MSSQL_USERNAME=sa TEST_MSSQL_PASSWORD=X@rmX@rm make test-mssql
[...]
coverage: 44.9% of statements
ok  	xorm.io/xorm/integrations	35.913s	coverage: 44.9% of statements
mssql test [fails](https://drone.gitea.com/xorm/xorm/1029/5/3): ``` db.Exec: lookup mssql on 127.0.0.11:53: no such host FAIL xorm.io/xorm/integrations 0.124s FAIL make: *** [Makefile:151: test-mssql] Error 1 ``` I locally tested this branch successfully using mssql: ``` $ git rev-parse HEAD 3da4fc74a30596ad6442aeeddd09a86aacf8f9a6 $ docker run -e "ACCEPT_EULA=Y" -e "SA_PASSWORD=X@rmX@rm" -e MSSQL_PID=Standard -p 1433:1433 -d mcr.microsoft.com/mssql/server:latest 4df2224ba61c4716a163e463c475cf85b496b801e08662aa1b9c26ff7ea1f02b $ docker inspect 4df2224ba61c4716a163e463c475cf85b496b801e08662aa1b9c26ff7ea1f02b -f "{{ .NetworkSettings.Networks.bridge.IPAddress }}" 172.18.0.4 $ TEST_MSSQL_HOST=172.18.0.4 TEST_MSSQL_DBNAME=xorm_test TEST_MSSQL_USERNAME=sa TEST_MSSQL_PASSWORD=X@rmX@rm make test-mssql [...] coverage: 44.9% of statements ok xorm.io/xorm/integrations 35.913s coverage: 44.9% of statements ```
lunny approved these changes 2022-04-17 10:03:22 +00:00
lunny merged commit ea9bba0d14 into master 2022-04-17 10:03:30 +00:00
pilou deleted branch postgresql_handle_column_comment 2022-04-22 02:51:28 +00:00
Sign in to join this conversation.
No description provided.