Remove const insertSelectPlaceholder and associated dead code #2151

zeripath · 2022-05-29T12:47:33Z

zeripath commented

2022-05-29 12:47:33 +00:00

insertSelectPlaceholder is an unexported const set at true. No code changes this nor can any build environment change it.

Therefore we should remove it and the associated dead code.

Close #2146

Signed-off-by: Andrew Thornton art27@cantab.net

`insertSelectPlaceholder` is an unexported const set at true. No code changes this nor can any build environment change it. Therefore we should remove it and the associated dead code. Close #2146 Signed-off-by: Andrew Thornton <art27@cantab.net>

zeripath added 1 commit 2022-05-29 12:47:34 +00:00

Remove const insertSelectPlaceholder and associated dead code

insertSelectPlaceholder is an unexported const set at true. No code changes this nor can
any build environment change it.

Therefore we should remove it and the associated dead code.

Signed-off-by: Andrew Thornton <art27@cantab.net>

continuous-integration/drone/pr Build is passing

Details

1d53848d50

lunny approved these changes 2022-05-29 16:28:56 +00:00

lunny merged commit 60540cbabe into master

2022-05-29 16:29:03 +00:00

lunny referenced this issue from a commit

2022-05-29 16:29:04 +00:00

Remove const insertSelectPlaceholder and associated dead code (#2151)

zeripath deleted branch no-insert-select-placeholder

2022-05-30 09:09:05 +00:00

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#2151