xorm.NewSyslogLogger doesn't work #353

New Issue

lunny · 2016-02-16T02:33:23Z

corvinusy commented

2016-02-16 02:33:23 +00:00

(Migrated from github.com)

Hello.
Problem: xorm syslogging doesn't write to system journal. All log messages still spam to console terminal.
Snippet:

    logWriter, err := syslog.New(syslog.LOG_DEBUG, "rest-xorm-example")
    if err != nil {
        log.Fatalf("Fail to create xorm system logger: %v\n", err)
    }
        s.engine.Logger = xorm.NewSyslogLogger(logWriter)
// next part with usual logger works fine
    // log.SetOutput(logWriter)
    // log.Println("hello rest-xorm-example")

Sources: github.com/corvinusy/rest-xorm-example

Testing environment:
Arch Linux: rolling
CPU: Intel(R) Core(TM) i5-2400 CPU @ 3.10GHz
uname -rm: 4.4.1-2-ARCH x86_64
go version: go version go1.6rc2 linux/amd64
xorm SQL backend: xorm.NewEngine("sqlite3", "/tmp/rest-xorm.sqlite.db")

Hello. Problem: xorm syslogging doesn't write to system journal. All log messages still spam to console terminal. Snippet: ``` go logWriter, err := syslog.New(syslog.LOG_DEBUG, "rest-xorm-example") if err != nil { log.Fatalf("Fail to create xorm system logger: %v\n", err) } s.engine.Logger = xorm.NewSyslogLogger(logWriter) // next part with usual logger works fine // log.SetOutput(logWriter) // log.Println("hello rest-xorm-example") ``` Sources: [github.com/corvinusy/rest-xorm-example](https://github.com/corvinusy/rest-xorm-example) Testing environment: Arch Linux: rolling CPU: Intel(R) Core(TM) i5-2400 CPU @ 3.10GHz uname -rm: 4.4.1-2-ARCH x86_64 go version: go version go1.6rc2 linux/amd64 xorm SQL backend: xorm.NewEngine("sqlite3", "/tmp/rest-xorm.sqlite.db")

lunny commented

2016-02-16 06:26:58 +00:00

I will check this issue.

lunny commented

2016-02-16 06:40:59 +00:00

Please use engine.SetLogger(logger) instead of engine.Logger = logger And I will change engine.Logger to engine.logger in next release.

Please use `engine.SetLogger(logger)` instead of `engine.Logger = logger` And I will change `engine.Logger` to `engine.logger` in next release.

corvinusy commented

2016-02-16 13:40:07 +00:00

(Migrated from github.com)

At this moment

engine.SetLogger(logger)

breaks build with error:
//// cannot use logWriter (type *syslog.Writer) as type core.ILogger in argument to s.engine.SetLogger: *syslog.Writer does not implement core.ILogger (wrong type for Debug method) have Debug(string) error want Debug(...interface {}) error

At this moment ``` go engine.SetLogger(logger) ``` breaks build with error: //// cannot use logWriter (type *syslog.Writer) as type core.ILogger in argument to s.engine.SetLogger: *syslog.Writer does not implement core.ILogger (wrong type for Debug method) have Debug(string) error want Debug(...interface {}) error

lunny commented

2016-02-16 14:37:49 +00:00

I mean

logWriter, err := syslog.New(syslog.LOG_DEBUG, "rest-xorm-example")
    if err != nil {
        log.Fatalf("Fail to create xorm system logger: %v\n", err)
    }
        s.engine.SetLogger(xorm.NewSyslogLogger(logWriter))

@corvinusy

I mean ``` Go logWriter, err := syslog.New(syslog.LOG_DEBUG, "rest-xorm-example") if err != nil { log.Fatalf("Fail to create xorm system logger: %v\n", err) } s.engine.SetLogger(xorm.NewSyslogLogger(logWriter)) ``` @corvinusy

lunny commented

2016-02-16 14:43:00 +00:00

OKay. I found that's my wrong. Just fix it. Please check again. @corvinusy

corvinusy commented

2016-02-16 15:12:01 +00:00

(Migrated from github.com)

Build fixed. Log gone from terminal.
But I still haven't found xorm log messages in journal (only "hello")
May be I should look in deeper.

Build fixed. Log gone from terminal. But I still haven't found xorm log messages in journal (only "hello") May be I should look in deeper.

lunny commented

2016-02-16 15:38:35 +00:00

Yes, I just found it.

lunny commented

2016-02-28 06:02:02 +00:00

I found if I changed

logWriter, err := syslog.New(syslog.LOG_DEBUG, "rest-xorm-example")

to

logWriter, err := syslog.New(syslog.LOG_ERR, "rest-xorm-example")

The log will be ok. But I don't know the reason.
@corvinusy

I found if I changed ``` Go logWriter, err := syslog.New(syslog.LOG_DEBUG, "rest-xorm-example") ``` to ``` Go logWriter, err := syslog.New(syslog.LOG_ERR, "rest-xorm-example") ``` The log will be ok. But I don't know the reason. @corvinusy

corvinusy commented

2016-02-28 18:33:05 +00:00

(Migrated from github.com)

Hey, @lunny

I've updated my example github.com/corvinusy/rest-xorm-example so logging to syslog works fine.

It seems there is no necessity for exported 'SyslogLogger' any more.
And perhaps it should be properly documented.

Hey, @lunny I've updated my example [github.com/corvinusy/rest-xorm-example](https://github.com/corvinusy/rest-xorm-example) so logging to syslog works fine. It seems there is no necessity for exported 'SyslogLogger' any more. And perhaps it should be properly documented.

lunny commented

2016-02-29 14:58:15 +00:00

Yes, I think you are right. SyslogLogger will be deprecated.

Yes, I think you are right. `SyslogLogger` will be deprecated.

corvinusy commented

2016-02-29 17:18:26 +00:00

(Migrated from github.com)

So I think the issue has been solved.
Of course, you can use any part of mentioned example for your goals/docs.

So I think the issue has been solved. Of course, you can use any part of mentioned example for your goals/docs.

lunny commented

2016-03-01 00:58:30 +00:00

Thanks.