xorm/xorm
xorm/xorm
63
357
Fork 207
Code Issues 373 Pull Requests 18 Actions 9 Releases 35 Activity

Logger Design Question #367

New Issue
Closed
opened 2016-03-07 14:37:13 +00:00 by mephux · 2 comments
mephux commented 2016-03-07 14:37:13 +00:00 (Migrated from github.com)
Copy Link

https://github.com/go-xorm/xorm/blob/master/logger.go#L78

Why do all of these return an error? This breaks compatibility with popular logging packages like logrus etc. Was just curious - not an error or even something that's important.

https://github.com/go-xorm/xorm/blob/master/logger.go#L78 Why do all of these return an error? This breaks compatibility with popular logging packages like logrus etc. Was just curious - not an error or even something that's important.
lunny commented 2016-03-08 06:57:38 +00:00
Copy Link

Hi, I think we can remove the return value here now.

Hi, I think we can remove the return value here now.
lunny commented 2016-06-30 09:19:03 +00:00
Copy Link

This issue has been resolved by b336fa1, so let's close it.

This issue has been resolved by b336fa1, so let's close it.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
v1
lunny/vul_scan
main
lunny/test_extends
lunny/oracle_ci
lunny/fix_distinct_count
lunny/postgres_for_update
lunny/executors
lunny/dm_ci
lunny/dm_upgrade
v1.3.9
v1.3.8
v1.3.7
v1.3.6
v1.3.4
v1.3.3
v1.3.2
v1.3.1
v1.3.0
v1.2.5
v1.2.4
v1.2.3
v1.2.2
v1.2.1
v1.2.0
v1.1.2
v1.1.1
v1.1.0
v1.0.7
v1.0.6
v1.0.5
v1.0.4
v1.0.3
v1.0.2
v1.0.1
v1.0.0
v0.8.2
v0.8.1
v0.8.0
v0.7.9
v0.7.8
v0.7.7
v0.7.6
v0.7.5
v0.7.4
v0.7.2
v0.7.3
v0.6.1
v0.7.1
v0.6.0
v0.7.0
v0.6.6
v0.6.5
v0.6.4
v0.6.3
v0.6.2
v0.5.8
v0.5.7
v0.5.6
v0.5.4
v0.5.3
v0.5.2
v0.5.1
v0.5.0
v0.4.5
v0.4.4
v0.4.3
v0.4.2
v0.4.1
v0.3.2
v0.3.1
v0.2.3
v0.2.2
v0.2.1
v0.2
Labels
Clear labels   
backport/done

   
backport/v1

   
blocked
  
db
oracle

  
db
sqlserver

  
duplicate
  
feature
cache

  
frontport/done

   
frontport/main

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependencies

  
kind
docs

  
kind
driver

  
kind
enhancement

  
kind
feature

  
kind
performance

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
testing

  
need
feedback

  
need
test

  
proposal:accepted

   
RaspBerry Pi

   
regression

   
skip-changelog

   
upstream

   
wip

   
wontfix
No Label
backport/done
backport/v1
blocked
db
oracle
db
sqlserver
duplicate
feature
cache
frontport/done
frontport/main
invalid
kind
breaking
kind
bug
kind
build
kind
dependencies
kind
docs
kind
driver
kind
enhancement
kind
feature
kind
performance
kind
proposal
kind
question
kind
refactor
kind
testing
need
feedback
need
test
proposal:accepted
RaspBerry Pi
regression
skip-changelog
upstream
wip
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#367
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?