Using English for code changes #380

Closed
opened 2016-04-20 18:11:53 +00:00 by ghost · 2 comments
ghost commented 2016-04-20 18:11:53 +00:00 (Migrated from github.com)

Hi,
Thanks for this great library. But sometimes it is very difficult to follow changes made to this lirary, when all the communication in a pull request or issue is in Chinese. Will it be possible always summarize code changes in English for a merged pull request where all or most prior messages are in Chinese?

Chrome does not suggest auto translate for Github. As a non-chinese speaker, it is hard to follow those cases. If I could go one step further, may I suggest that titles of issues and pull requests are encouraged to be in English (may be mentioned in the readme file), so that at least non-chinese speakers like me know when to dig in further into an issue or pull request with the help of Google translate.

Thanks.

Hi, Thanks for this great library. But sometimes it is very difficult to follow changes made to this lirary, when all the communication in a pull request or issue is in Chinese. Will it be possible always summarize code changes in English for a _merged pull request_ where all or most prior messages are in Chinese? Chrome does not suggest auto translate for Github. As a non-chinese speaker, it is hard to follow those cases. If I could go one step further, may I suggest that titles of issues and pull requests are encouraged to be in English (may be mentioned in the readme file), so that at least non-chinese speakers like me know when to dig in further into an issue or pull request with the help of Google translate. Thanks.

Hi, I think this is a good idea. I will add some a language description on README for issues and PRs. Thanks!

Hi, I think this is a good idea. I will add some a language description on README for issues and PRs. Thanks!

I have added a notice on CONTRIBUTING.md.

I have added a notice on `CONTRIBUTING.md`.
lunny referenced this issue from a commit 2020-03-09 02:52:44 +00:00
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#380
No description provided.