Get ignores varchar(max) conditions for MSSQL #523

New Issue

lunny · 2017-01-19T03:15:26Z

btrepp commented

2017-01-19 03:15:26 +00:00

(Migrated from github.com)

From https://github.com/go-gitea/gitea/issues/697

It appears that
has, err := x.Get(&PublicKey{ Content: content, Type: KeyTypeUser, })
Where content is of type varchar(max). The content query condition is ignored. This ends up checking on the type condition, and returning incorrect values.

MSSQL does support querying on text columns. Eg the below works
has, err := x.Where("content=?",content).Where("type=?",KeyTypeUser).Get(&PublicKey{})

Go-xorm should either support that in the "bean" or error out if it is not supported. Silently dropping it leads to unexpected results.

From https://github.com/go-gitea/gitea/issues/697 It appears that ```has, err := x.Get(&PublicKey{ Content: content, Type: KeyTypeUser, })``` Where content is of type `varchar(max)`. The content query condition is ignored. This ends up checking on the type condition, and returning incorrect values. MSSQL does support querying on text columns. Eg the below works ``` has, err := x.Where("content=?",content).Where("type=?",KeyTypeUser).Get(&PublicKey{})``` Go-xorm should either support that in the "bean" or error out if it is not supported. Silently dropping it leads to unexpected results.

lunny commented

2017-02-12 03:45:10 +00:00

This is because MSSQL don't support use TEXT column as query condition. So xorm will ignore it.

This is because MSSQL don't support use `TEXT` column as query condition. So xorm will ignore it.

lunny modified the milestone from 0.8.2 to 1.1.1

2020-02-21 02:52:12 +00:00

lunny modified the milestone from 1.1.1 to 1.3.0

2021-06-07 07:45:26 +00:00

lunny commented

2021-08-08 08:07:57 +00:00

Maybe we should give an error clearly.

lunny added