add more tests #595

lunny · 2017-05-30T09:16:42Z

lunny commented

2017-05-30 09:16:42 +00:00

No description provided.

codecov-io commented

2017-05-30 12:29:32 +00:00

(Migrated from github.com)

Codecov Report

Merging #595 into master will increase coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #595      +/-   ##
==========================================
+ Coverage   40.15%   40.39%   +0.24%     
==========================================
  Files          30       30              
  Lines        6921     6921              
==========================================
+ Hits         2779     2796      +17     
+ Misses       3643     3640       -3     
+ Partials      499      485      -14

Impacted Files	Coverage Δ
dialect_postgres.go	`0% <0%> (-61.98%)`	⬇️
session_insert.go	`34.51% <0%> (-3.84%)`	⬇️
convert.go	`21.22% <0%> (-2.05%)`	⬇️
xorm.go	`65.45% <0%> (-1.82%)`	⬇️
session_update.go	`30.56% <0%> (-1.75%)`	⬇️
helpers.go	`46.41% <0%> (-0.48%)`	⬇️
session_get.go	`38.33% <0%> (+2.5%)`	⬆️
engine.go	`50.11% <0%> (+3.25%)`	⬆️
session.go	`43.92% <0%> (+5.87%)`	⬆️
session_find.go	`57% <0%> (+6.18%)`	⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e266fb7...19b1270. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/595?src=pr&el=h1) Report > Merging [#595](https://codecov.io/gh/go-xorm/xorm/pull/595?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/e266fb7af1d9bf21e822a5e66874294b9a7ae9c7?src=pr&el=desc) will **increase** coverage by `0.24%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/595/graphs/tree.svg?src=pr&token=yB5nO1krEe&width=650&height=150)](https://codecov.io/gh/go-xorm/xorm/pull/595?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #595 +/- ## ========================================== + Coverage 40.15% 40.39% +0.24% ========================================== Files 30 30 Lines 6921 6921 ========================================== + Hits 2779 2796 +17 + Misses 3643 3640 -3 + Partials 499 485 -14 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/595?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [dialect\_postgres.go](https://codecov.io/gh/go-xorm/xorm/pull/595?src=pr&el=tree#diff-ZGlhbGVjdF9wb3N0Z3Jlcy5nbw==) | `0% <0%> (-61.98%)` | :arrow_down: | | [session\_insert.go](https://codecov.io/gh/go-xorm/xorm/pull/595?src=pr&el=tree#diff-c2Vzc2lvbl9pbnNlcnQuZ28=) | `34.51% <0%> (-3.84%)` | :arrow_down: | | [convert.go](https://codecov.io/gh/go-xorm/xorm/pull/595?src=pr&el=tree#diff-Y29udmVydC5nbw==) | `21.22% <0%> (-2.05%)` | :arrow_down: | | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/595?src=pr&el=tree#diff-eG9ybS5nbw==) | `65.45% <0%> (-1.82%)` | :arrow_down: | | [session\_update.go](https://codecov.io/gh/go-xorm/xorm/pull/595?src=pr&el=tree#diff-c2Vzc2lvbl91cGRhdGUuZ28=) | `30.56% <0%> (-1.75%)` | :arrow_down: | | [helpers.go](https://codecov.io/gh/go-xorm/xorm/pull/595?src=pr&el=tree#diff-aGVscGVycy5nbw==) | `46.41% <0%> (-0.48%)` | :arrow_down: | | [session\_get.go](https://codecov.io/gh/go-xorm/xorm/pull/595?src=pr&el=tree#diff-c2Vzc2lvbl9nZXQuZ28=) | `38.33% <0%> (+2.5%)` | :arrow_up: | | [engine.go](https://codecov.io/gh/go-xorm/xorm/pull/595?src=pr&el=tree#diff-ZW5naW5lLmdv) | `50.11% <0%> (+3.25%)` | :arrow_up: | | [session.go](https://codecov.io/gh/go-xorm/xorm/pull/595?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `43.92% <0%> (+5.87%)` | :arrow_up: | | [session\_find.go](https://codecov.io/gh/go-xorm/xorm/pull/595?src=pr&el=tree#diff-c2Vzc2lvbl9maW5kLmdv) | `57% <0%> (+6.18%)` | :arrow_up: | | ... and [5 more](https://codecov.io/gh/go-xorm/xorm/pull/595?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/595?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/595?src=pr&el=footer). Last update [e266fb7...19b1270](https://codecov.io/gh/go-xorm/xorm/pull/595?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny referenced this issue from a commit

2020-01-19 09:34:09 +00:00

add more tests (#595) * add more tests * fix tests

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#595