fix distinct & top conflict on mssql #596

lunny · 2017-05-30T10:19:18Z

lunny commented

2017-05-30 10:19:18 +00:00

will fix #593

codecov-io commented

2017-05-30 10:23:10 +00:00

(Migrated from github.com)

Codecov Report

Merging #596 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #596   +/-   ##
=======================================
  Coverage   43.61%   43.61%           
=======================================
  Files          30       30           
  Lines        6925     6925           
=======================================
  Hits         3020     3020           
  Misses       3399     3399           
  Partials      506      506

Impacted Files	Coverage Δ
statement.go	`53.71% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7154d2c...b4bf2d5. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/596?src=pr&el=h1) Report > Merging [#596](https://codecov.io/gh/go-xorm/xorm/pull/596?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/7154d2c42d9d817f089cde3b7fb7b22d355ef4a6?src=pr&el=desc) will **not change** coverage. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/596/graphs/tree.svg?token=yB5nO1krEe&width=650&height=150&src=pr)](https://codecov.io/gh/go-xorm/xorm/pull/596?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #596 +/- ## ======================================= Coverage 43.61% 43.61% ======================================= Files 30 30 Lines 6925 6925 ======================================= Hits 3020 3020 Misses 3399 3399 Partials 506 506 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/596?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [statement.go](https://codecov.io/gh/go-xorm/xorm/pull/596?src=pr&el=tree#diff-c3RhdGVtZW50Lmdv) | `53.71% <100%> (ø)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/596?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/596?src=pr&el=footer). Last update [7154d2c...b4bf2d5](https://codecov.io/gh/go-xorm/xorm/pull/596?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny referenced this issue from a commit

2020-01-19 09:34:09 +00:00

fix distinct & top conflict on mssql (#596)

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#596