add more tests #600

lunny · 2017-05-31T07:40:30Z

lunny commented

2017-05-31 07:40:30 +00:00

No description provided.

codecov-io commented

2017-05-31 08:06:58 +00:00

(Migrated from github.com)

Codecov Report

Merging #600 into master will increase coverage by 2.84%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #600      +/-   ##
==========================================
+ Coverage   45.28%   48.12%   +2.84%     
==========================================
  Files          30       30              
  Lines        6925     6925              
==========================================
+ Hits         3136     3333     +197     
+ Misses       3289     3126     -163     
+ Partials      500      466      -34

Impacted Files	Coverage Δ
xorm.go	`67.27% <0%> (ø)`	⬆️
engine.go	`53.68% <0%> (+0.44%)`	⬆️
session_convert.go	`21.72% <0%> (+0.61%)`	⬆️
statement.go	`57.14% <0%> (+1.6%)`	⬆️
session_find.go	`58.95% <0%> (+1.95%)`	⬆️
convert.go	`28.57% <0%> (+2.04%)`	⬆️
session.go	`50.4% <0%> (+2.42%)`	⬆️
rows.go	`43.03% <0%> (+2.53%)`	⬆️
tag.go	`66.92% <0%> (+3.14%)`	⬆️
helpers.go	`53.34% <0%> (+4.3%)`	⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9033c97...d7ef17a. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/600?src=pr&el=h1) Report > Merging [#600](https://codecov.io/gh/go-xorm/xorm/pull/600?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/9033c97e4d0ea1eb50fddabb3eaf84690f9065ce?src=pr&el=desc) will **increase** coverage by `2.84%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/600/graphs/tree.svg?width=650&height=150&src=pr&token=yB5nO1krEe)](https://codecov.io/gh/go-xorm/xorm/pull/600?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #600 +/- ## ========================================== + Coverage 45.28% 48.12% +2.84% ========================================== Files 30 30 Lines 6925 6925 ========================================== + Hits 3136 3333 +197 + Misses 3289 3126 -163 + Partials 500 466 -34 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/600?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/600?src=pr&el=tree#diff-eG9ybS5nbw==) | `67.27% <0%> (ø)` | :arrow_up: | | [engine.go](https://codecov.io/gh/go-xorm/xorm/pull/600?src=pr&el=tree#diff-ZW5naW5lLmdv) | `53.68% <0%> (+0.44%)` | :arrow_up: | | [session\_convert.go](https://codecov.io/gh/go-xorm/xorm/pull/600?src=pr&el=tree#diff-c2Vzc2lvbl9jb252ZXJ0Lmdv) | `21.72% <0%> (+0.61%)` | :arrow_up: | | [statement.go](https://codecov.io/gh/go-xorm/xorm/pull/600?src=pr&el=tree#diff-c3RhdGVtZW50Lmdv) | `57.14% <0%> (+1.6%)` | :arrow_up: | | [session\_find.go](https://codecov.io/gh/go-xorm/xorm/pull/600?src=pr&el=tree#diff-c2Vzc2lvbl9maW5kLmdv) | `58.95% <0%> (+1.95%)` | :arrow_up: | | [convert.go](https://codecov.io/gh/go-xorm/xorm/pull/600?src=pr&el=tree#diff-Y29udmVydC5nbw==) | `28.57% <0%> (+2.04%)` | :arrow_up: | | [session.go](https://codecov.io/gh/go-xorm/xorm/pull/600?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `50.4% <0%> (+2.42%)` | :arrow_up: | | [rows.go](https://codecov.io/gh/go-xorm/xorm/pull/600?src=pr&el=tree#diff-cm93cy5nbw==) | `43.03% <0%> (+2.53%)` | :arrow_up: | | [tag.go](https://codecov.io/gh/go-xorm/xorm/pull/600?src=pr&el=tree#diff-dGFnLmdv) | `66.92% <0%> (+3.14%)` | :arrow_up: | | [helpers.go](https://codecov.io/gh/go-xorm/xorm/pull/600?src=pr&el=tree#diff-aGVscGVycy5nbw==) | `53.34% <0%> (+4.3%)` | :arrow_up: | | ... and [7 more](https://codecov.io/gh/go-xorm/xorm/pull/600?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/600?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/600?src=pr&el=footer). Last update [9033c97...d7ef17a](https://codecov.io/gh/go-xorm/xorm/pull/600?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny referenced this issue from a commit

2020-01-19 09:34:09 +00:00

add more tests (#600) * add more tests * fix tests

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#600