fix time issues and add some tests for time #604

lunny · 2017-06-01T15:20:53Z

lunny commented

2017-06-01 15:20:53 +00:00

No description provided.

codecov-io commented

2017-06-02 02:05:00 +00:00

(Migrated from github.com)

Codecov Report

Merging #604 into master will decrease coverage by 0.01%.
The diff coverage is 52%.

@@            Coverage Diff            @@
##           master    #604      +/-   ##
=========================================
- Coverage   49.71%   49.7%   -0.02%     
=========================================
  Files          30      31       +1     
  Lines        6933    6929       -4     
=========================================
- Hits         3447    3444       -3     
  Misses       3025    3025              
+ Partials      461     460       -1

Impacted Files	Coverage Δ
helpers.go	`53.72% <ø> (-1.55%)`	⬇️
session_update.go	`50.42% <0%> (-1.99%)`	⬇️
statement.go	`61.37% <0%> (ø)`	⬆️
dialect_mssql.go	`0% <0%> (ø)`	⬆️
session_insert.go	`57.34% <100%> (ø)`	⬆️
xorm.go	`69.49% <100%> (+2.21%)`	⬆️
helpler_time.go	`100% <100%> (ø)`
session_convert.go	`21.69% <36.36%> (-0.44%)`	⬇️
session_raw.go	`60.31% <59.63%> (-0.94%)`	⬇️
session.go	`50.2% <60%> (-0.81%)`	⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c179e4...7788ac7. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/604?src=pr&el=h1) Report > Merging [#604](https://codecov.io/gh/go-xorm/xorm/pull/604?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/9c179e47a16c8449e492d9d3f9f5131751ff7e31?src=pr&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `52%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/604/graphs/tree.svg?width=650&src=pr&token=yB5nO1krEe&height=150)](https://codecov.io/gh/go-xorm/xorm/pull/604?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #604 +/- ## ========================================= - Coverage 49.71% 49.7% -0.02% ========================================= Files 30 31 +1 Lines 6933 6929 -4 ========================================= - Hits 3447 3444 -3 Misses 3025 3025 + Partials 461 460 -1 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/604?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [helpers.go](https://codecov.io/gh/go-xorm/xorm/pull/604?src=pr&el=tree#diff-aGVscGVycy5nbw==) | `53.72% <ø> (-1.55%)` | :arrow_down: | | [session\_update.go](https://codecov.io/gh/go-xorm/xorm/pull/604?src=pr&el=tree#diff-c2Vzc2lvbl91cGRhdGUuZ28=) | `50.42% <0%> (-1.99%)` | :arrow_down: | | [statement.go](https://codecov.io/gh/go-xorm/xorm/pull/604?src=pr&el=tree#diff-c3RhdGVtZW50Lmdv) | `61.37% <0%> (ø)` | :arrow_up: | | [dialect\_mssql.go](https://codecov.io/gh/go-xorm/xorm/pull/604?src=pr&el=tree#diff-ZGlhbGVjdF9tc3NxbC5nbw==) | `0% <0%> (ø)` | :arrow_up: | | [session\_insert.go](https://codecov.io/gh/go-xorm/xorm/pull/604?src=pr&el=tree#diff-c2Vzc2lvbl9pbnNlcnQuZ28=) | `57.34% <100%> (ø)` | :arrow_up: | | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/604?src=pr&el=tree#diff-eG9ybS5nbw==) | `69.49% <100%> (+2.21%)` | :arrow_up: | | [helpler\_time.go](https://codecov.io/gh/go-xorm/xorm/pull/604?src=pr&el=tree#diff-aGVscGxlcl90aW1lLmdv) | `100% <100%> (ø)` | | | [session\_convert.go](https://codecov.io/gh/go-xorm/xorm/pull/604?src=pr&el=tree#diff-c2Vzc2lvbl9jb252ZXJ0Lmdv) | `21.69% <36.36%> (-0.44%)` | :arrow_down: | | [session\_raw.go](https://codecov.io/gh/go-xorm/xorm/pull/604?src=pr&el=tree#diff-c2Vzc2lvbl9yYXcuZ28=) | `60.31% <59.63%> (-0.94%)` | :arrow_down: | | [session.go](https://codecov.io/gh/go-xorm/xorm/pull/604?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `50.2% <60%> (-0.81%)` | :arrow_down: | | ... and [3 more](https://codecov.io/gh/go-xorm/xorm/pull/604?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/604?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/604?src=pr&el=footer). Last update [9c179e4...7788ac7](https://codecov.io/gh/go-xorm/xorm/pull/604?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny commented

2017-06-02 03:29:12 +00:00

will fix #310 #324 #556 #585 and drop #581