fix bug and add set conn max lifetime #606

lunny · 2017-06-05T04:27:36Z

lunny commented

2017-06-05 04:27:36 +00:00

will fix #605 and #491

codecov-io commented

2017-06-05 06:41:12 +00:00

(Migrated from github.com)

Codecov Report

Merging #606 into master will increase coverage by 0.14%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #606      +/-   ##
==========================================
+ Coverage    49.7%   49.84%   +0.14%     
==========================================
  Files          31       31              
  Lines        6929     6939      +10     
==========================================
+ Hits         3444     3459      +15     
+ Misses       3025     3020       -5     
  Partials      460      460

Impacted Files	Coverage Δ
xorm.go	`69.49% <ø> (ø)`	⬆️
engine.go	`56.94% <0%> (-0.14%)`	⬇️
dialect_sqlite3.go	`78.04% <100%> (+1.9%)`	⬆️
dialect_postgres.go	`67.6% <0%> (+0.7%)`	⬆️
dialect_mysql.go	`55.71% <0%> (+1.07%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 942887d...b406f97. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/606?src=pr&el=h1) Report > Merging [#606](https://codecov.io/gh/go-xorm/xorm/pull/606?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/942887dea0b0878ce54d709857ef5bc0f2e3b274?src=pr&el=desc) will **increase** coverage by `0.14%`. > The diff coverage is `80%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/606/graphs/tree.svg?token=yB5nO1krEe&width=650&height=150&src=pr)](https://codecov.io/gh/go-xorm/xorm/pull/606?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #606 +/- ## ========================================== + Coverage 49.7% 49.84% +0.14% ========================================== Files 31 31 Lines 6929 6939 +10 ========================================== + Hits 3444 3459 +15 + Misses 3025 3020 -5 Partials 460 460 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/606?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/606?src=pr&el=tree#diff-eG9ybS5nbw==) | `69.49% <ø> (ø)` | :arrow_up: | | [engine.go](https://codecov.io/gh/go-xorm/xorm/pull/606?src=pr&el=tree#diff-ZW5naW5lLmdv) | `56.94% <0%> (-0.14%)` | :arrow_down: | | [dialect\_sqlite3.go](https://codecov.io/gh/go-xorm/xorm/pull/606?src=pr&el=tree#diff-ZGlhbGVjdF9zcWxpdGUzLmdv) | `78.04% <100%> (+1.9%)` | :arrow_up: | | [dialect\_postgres.go](https://codecov.io/gh/go-xorm/xorm/pull/606?src=pr&el=tree#diff-ZGlhbGVjdF9wb3N0Z3Jlcy5nbw==) | `67.6% <0%> (+0.7%)` | :arrow_up: | | [dialect\_mysql.go](https://codecov.io/gh/go-xorm/xorm/pull/606?src=pr&el=tree#diff-ZGlhbGVjdF9teXNxbC5nbw==) | `55.71% <0%> (+1.07%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/606?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/606?src=pr&el=footer). Last update [942887d...b406f97](https://codecov.io/gh/go-xorm/xorm/pull/606?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny referenced this issue from a commit

2020-01-19 09:34:09 +00:00

fix bug and add set conn max lifetime (#606) * fix sqlite bug and add SetConnMaxLifetime * add parse for composite keys * required go 1.5+

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#606