Go 1.5 support #611

New Issue

lunny · 2017-06-07T05:27:58Z

unknwon commented

2017-06-07 05:27:58 +00:00

(Migrated from github.com)

Hi, if I want to compile XORM with Go 1.5, it is no longer possible with compile error:

vendor/github.com/go-xorm/xorm/engine.go:200: engine.db.SetConnMaxLifetime undefined (type *core.DB has no field or method SetConnMaxLifetime)

I'm not sure Go 1.5 is officially dropped support or just didn't notice this problem?

Thanks.

Hi, if I want to compile XORM with Go 1.5, it is no longer possible with compile error: ``` vendor/github.com/go-xorm/xorm/engine.go:200: engine.db.SetConnMaxLifetime undefined (type *core.DB has no field or method SetConnMaxLifetime) ``` I'm not sure Go 1.5 is officially dropped support or just didn't notice this problem? Thanks.

lunny commented

2017-06-08 01:37:26 +00:00

I just noticed SetConnMaxLifetime is introduced by go1.6, not go1.5 and I will send a PR to fix the requirement.
I have to say yes, we will drop go1.1 ~ go 1.5 and go1.6 is the minimal requirement.

I just noticed `SetConnMaxLifetime` is introduced by go1.6, not go1.5 and I will send a PR to fix the requirement. I have to say yes, we will drop go1.1 ~ go 1.5 and go1.6 is the minimal requirement.

unknwon commented

2017-06-08 01:39:45 +00:00

(Migrated from github.com)

AFAIK, back support is just a simple fix to add a file only compile under go1.6 and manually copy code. But that's OK if you don't want, thanks for the confirmation.

Sign in to join this conversation.

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#611