move lifetime to a split file so that go1.1 is also work with this feature #612

lunny · 2017-06-08T02:16:25Z

lunny commented

2017-06-08 02:16:25 +00:00

related #611

codecov-io commented

2017-06-08 02:16:28 +00:00

(Migrated from github.com)

Codecov Report

Merging #612 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #612   +/-   ##
=======================================
  Coverage   49.87%   49.87%           
=======================================
  Files          31       32    +1     
  Lines        6941     6941           
=======================================
  Hits         3462     3462           
  Misses       3019     3019           
  Partials      460      460

Impacted Files	Coverage Δ
engine.go	`57.07% <ø> (+0.13%)`	⬆️
engine_maxlife.go	`0% <0%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a87763...466cc53. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/612?src=pr&el=h1) Report > Merging [#612](https://codecov.io/gh/go-xorm/xorm/pull/612?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/8a877636fdbbb0f7133b158fe5cde3588464b035?src=pr&el=desc) will **not change** coverage. > The diff coverage is `0%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/612/graphs/tree.svg?height=150&width=650&token=yB5nO1krEe&src=pr)](https://codecov.io/gh/go-xorm/xorm/pull/612?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #612 +/- ## ======================================= Coverage 49.87% 49.87% ======================================= Files 31 32 +1 Lines 6941 6941 ======================================= Hits 3462 3462 Misses 3019 3019 Partials 460 460 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/612?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [engine.go](https://codecov.io/gh/go-xorm/xorm/pull/612?src=pr&el=tree#diff-ZW5naW5lLmdv) | `57.07% <ø> (+0.13%)` | :arrow_up: | | [engine\_maxlife.go](https://codecov.io/gh/go-xorm/xorm/pull/612?src=pr&el=tree#diff-ZW5naW5lX21heGxpZmUuZ28=) | `0% <0%> (ø)` | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/612?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/612?src=pr&el=footer). Last update [8a87763...466cc53](https://codecov.io/gh/go-xorm/xorm/pull/612?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny referenced this issue from a commit

2020-01-19 09:34:09 +00:00

move lifetime to a split file so that go1.1 is also work with this feature (#612)

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#612