close rows if possible #629

lunny · 2017-06-25T08:42:11Z

lunny commented

2017-06-25 08:42:11 +00:00

This PR will close rows as we can.

codecov-io commented

2017-06-25 08:45:09 +00:00

(Migrated from github.com)

Codecov Report

Merging #629 into master will increase coverage by <.01%.
The diff coverage is 69.69%.

@@            Coverage Diff             @@
##           master     #629      +/-   ##
==========================================
+ Coverage   49.65%   49.65%   +<.01%     
==========================================
  Files          33       33              
  Lines        7020     7032      +12     
==========================================
+ Hits         3486     3492       +6     
- Misses       3066     3069       +3     
- Partials      468      471       +3

Impacted Files	Coverage Δ
rows.go	`41.66% <50%> (-0.31%)`	⬇️
session.go	`50.3% <71.42%> (+0.09%)`	⬆️
session_get.go	`41.73% <72.72%> (+0.26%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9e6f21...e757de5. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/629?src=pr&el=h1) Report > Merging [#629](https://codecov.io/gh/go-xorm/xorm/pull/629?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/d9e6f21d604f9363563c1b6432b43e82b6c630f7?src=pr&el=desc) will **increase** coverage by `<.01%`. > The diff coverage is `69.69%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/629/graphs/tree.svg?token=yB5nO1krEe&src=pr&width=650&height=150)](https://codecov.io/gh/go-xorm/xorm/pull/629?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #629 +/- ## ========================================== + Coverage 49.65% 49.65% +<.01% ========================================== Files 33 33 Lines 7020 7032 +12 ========================================== + Hits 3486 3492 +6 - Misses 3066 3069 +3 - Partials 468 471 +3 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/629?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [rows.go](https://codecov.io/gh/go-xorm/xorm/pull/629?src=pr&el=tree#diff-cm93cy5nbw==) | `41.66% <50%> (-0.31%)` | :arrow_down: | | [session.go](https://codecov.io/gh/go-xorm/xorm/pull/629?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `50.3% <71.42%> (+0.09%)` | :arrow_up: | | [session\_get.go](https://codecov.io/gh/go-xorm/xorm/pull/629?src=pr&el=tree#diff-c2Vzc2lvbl9nZXQuZ28=) | `41.73% <72.72%> (+0.26%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/629?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/629?src=pr&el=footer). Last update [d9e6f21...e757de5](https://codecov.io/gh/go-xorm/xorm/pull/629?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny referenced this issue from a commit

2020-01-19 09:34:10 +00:00

close rows if possible (#629)

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#629