xorm/xorm
xorm/xorm
63
356
Fork 206
Code Issues 371 Pull Requests 18 Actions Releases 35 Activity

More clear log #638

Merged
oherych merged 1 commits from patch-1 into master 2017-07-11 01:16:08 +00:00
Conversation 2 Commits 1 Files Changed 1 +1 -1
oherych commented 2017-07-10 15:41:07 +00:00 (Migrated from github.com)
Copy Link

I don't see nil and empty strings in log. I suggest the next changes

Before

INSERT INTO `dish` (`dish_id`,`restaurant_id`,`name`,`source`,`entry_id`,`created_by`,`menu_id`,`category`,`description`,`price`,`score`,`flog_count`,`approve`,`activated`,`created_at`,`updatated_at`) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) [59639fb56d9d9437b707a434 58a313719fee7b336da70c45 Chocolate Mousse Torte fsqi 51339970   Dessert Seasonal berry sauce 0 0 0 1 false 2017-07-10 18:39:33 2017-07-10 18:39:33]

After

INSERT INTO `dish` (`dish_id`,`restaurant_id`,`name`,`source`,`entry_id`,`created_by`,`menu_id`,`category`,`description`,`price`,`score`,`flog_count`,`approve`,`activated`,`created_at`,`updatated_at`) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) []interface {}{"59639ec16d9d943782ce2f6c", "58a313719fee7b336da70c45", "Chocolate Mousse Torte", "fsqi", "51339970", "", "", "Dessert", "Seasonal berry sauce", 0, 0, 0, 1, false, "2017-07-10 18:35:29", "2017-07-10 18:35:29"}
I don't see `nil` and empty strings in log. I suggest the next changes **Before** ``` INSERT INTO `dish` (`dish_id`,`restaurant_id`,`name`,`source`,`entry_id`,`created_by`,`menu_id`,`category`,`description`,`price`,`score`,`flog_count`,`approve`,`activated`,`created_at`,`updatated_at`) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) [59639fb56d9d9437b707a434 58a313719fee7b336da70c45 Chocolate Mousse Torte fsqi 51339970 Dessert Seasonal berry sauce 0 0 0 1 false 2017-07-10 18:39:33 2017-07-10 18:39:33] ``` **After** ``` INSERT INTO `dish` (`dish_id`,`restaurant_id`,`name`,`source`,`entry_id`,`created_by`,`menu_id`,`category`,`description`,`price`,`score`,`flog_count`,`approve`,`activated`,`created_at`,`updatated_at`) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) []interface {}{"59639ec16d9d943782ce2f6c", "58a313719fee7b336da70c45", "Chocolate Mousse Torte", "fsqi", "51339970", "", "", "Dessert", "Seasonal berry sauce", 0, 0, 0, 1, false, "2017-07-10 18:35:29", "2017-07-10 18:35:29"} ```
codecov-io commented 2017-07-10 15:45:50 +00:00 (Migrated from github.com)
Copy Link

Codecov Report

Merging #638 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #638   +/-   ##
=======================================
  Coverage   49.53%   49.53%           
=======================================
  Files          33       33           
  Lines        7039     7039           
=======================================
  Hits         3487     3487           
  Misses       3077     3077           
  Partials      475      475
Impacted Files Coverage Δ
engine.go 56.74% <100%> (ø) ⬆️
xorm.go 69.49% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39a812d...abe8474. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/638?src=pr&el=h1) Report > Merging [#638](https://codecov.io/gh/go-xorm/xorm/pull/638?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/39a812d59d149c55af8a80c3fba3c79771b45df1?src=pr&el=desc) will **not change** coverage. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/638/graphs/tree.svg?token=yB5nO1krEe&src=pr&height=150&width=650)](https://codecov.io/gh/go-xorm/xorm/pull/638?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #638 +/- ## ======================================= Coverage 49.53% 49.53% ======================================= Files 33 33 Lines 7039 7039 ======================================= Hits 3487 3487 Misses 3077 3077 Partials 475 475 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/638?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [engine.go](https://codecov.io/gh/go-xorm/xorm/pull/638?src=pr&el=tree#diff-ZW5naW5lLmdv) | `56.74% <100%> (ø)` | :arrow_up: | | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/638?src=pr&el=tree#diff-eG9ybS5nbw==) | `69.49% <0%> (ø)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/638?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/638?src=pr&el=footer). Last update [39a812d...abe8474](https://codecov.io/gh/go-xorm/xorm/pull/638?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
lunny commented 2017-07-11 01:16:15 +00:00
Copy Link

Thanks!

Thanks!
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backport/done

   
backport/v1

   
blocked
  
db
oracle

  
db
sqlserver

  
duplicate
  
feature
cache

  
frontport/done

   
frontport/main

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependencies

  
kind
docs

  
kind
driver

  
kind
enhancement

  
kind
feature

  
kind
performance

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
testing

  
need
feedback

  
need
test

  
proposal:accepted

   
RaspBerry Pi

   
regression

   
skip-changelog

   
upstream

   
wip

   
wontfix
No Label
backport/done
backport/v1
blocked
db
oracle
db
sqlserver
duplicate
feature
cache
frontport/done
frontport/main
invalid
kind
breaking
kind
bug
kind
build
kind
dependencies
kind
docs
kind
driver
kind
enhancement
kind
feature
kind
performance
kind
proposal
kind
question
kind
refactor
kind
testing
need
feedback
need
test
proposal:accepted
RaspBerry Pi
regression
skip-changelog
upstream
wip
wontfix
Milestone
Clear milestone
No items
No Milestone
0.7
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#638
No description provided.
Delete Branch "patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?