improve update error when no conent to be updated #648

lunny · 2017-07-21T08:38:46Z

lunny commented

2017-07-21 08:38:46 +00:00

fix #647

codecov-io commented

2017-07-21 08:42:42 +00:00

(Migrated from github.com)

Codecov Report

Merging #648 into master will decrease coverage by 1.6%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #648      +/-   ##
==========================================
- Coverage   49.67%   48.06%   -1.61%     
==========================================
  Files          34       34              
  Lines        7090     8359    +1269     
==========================================
+ Hits         3522     4018     +496     
- Misses       3085     3856     +771     
- Partials      483      485       +2

Impacted Files	Coverage Δ
session_update.go	`48.06% <100%> (-0.93%)`	⬇️
session_iterate.go	`59.09% <0%> (-7.58%)`	⬇️
session_schema.go	`52.45% <0%> (-5.43%)`	⬇️
session_exist.go	`60.65% <0%> (-5.31%)`	⬇️
session_raw.go	`56.7% <0%> (-3.61%)`	⬇️
session_sum.go	`45.27% <0%> (-3.45%)`	⬇️
engine.go	`54.11% <0%> (-2.83%)`	⬇️
cache_lru.go	`40.32% <0%> (-2.45%)`	⬇️
xorm.go	`67.14% <0%> (-2.35%)`	⬇️
session_find.go	`56.09% <0%> (-2.24%)`	⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 774f83c...9bd63bb. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/648?src=pr&el=h1) Report > Merging [#648](https://codecov.io/gh/go-xorm/xorm/pull/648?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/774f83c1bc04aca2a136270778d70ba0212d25d5?src=pr&el=desc) will **decrease** coverage by `1.6%`. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/648/graphs/tree.svg?token=yB5nO1krEe&width=650&src=pr&height=150)](https://codecov.io/gh/go-xorm/xorm/pull/648?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #648 +/- ## ========================================== - Coverage 49.67% 48.06% -1.61% ========================================== Files 34 34 Lines 7090 8359 +1269 ========================================== + Hits 3522 4018 +496 - Misses 3085 3856 +771 - Partials 483 485 +2 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/648?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [session\_update.go](https://codecov.io/gh/go-xorm/xorm/pull/648?src=pr&el=tree#diff-c2Vzc2lvbl91cGRhdGUuZ28=) | `48.06% <100%> (-0.93%)` | :arrow_down: | | [session\_iterate.go](https://codecov.io/gh/go-xorm/xorm/pull/648?src=pr&el=tree#diff-c2Vzc2lvbl9pdGVyYXRlLmdv) | `59.09% <0%> (-7.58%)` | :arrow_down: | | [session\_schema.go](https://codecov.io/gh/go-xorm/xorm/pull/648?src=pr&el=tree#diff-c2Vzc2lvbl9zY2hlbWEuZ28=) | `52.45% <0%> (-5.43%)` | :arrow_down: | | [session\_exist.go](https://codecov.io/gh/go-xorm/xorm/pull/648?src=pr&el=tree#diff-c2Vzc2lvbl9leGlzdC5nbw==) | `60.65% <0%> (-5.31%)` | :arrow_down: | | [session\_raw.go](https://codecov.io/gh/go-xorm/xorm/pull/648?src=pr&el=tree#diff-c2Vzc2lvbl9yYXcuZ28=) | `56.7% <0%> (-3.61%)` | :arrow_down: | | [session\_sum.go](https://codecov.io/gh/go-xorm/xorm/pull/648?src=pr&el=tree#diff-c2Vzc2lvbl9zdW0uZ28=) | `45.27% <0%> (-3.45%)` | :arrow_down: | | [engine.go](https://codecov.io/gh/go-xorm/xorm/pull/648?src=pr&el=tree#diff-ZW5naW5lLmdv) | `54.11% <0%> (-2.83%)` | :arrow_down: | | [cache\_lru.go](https://codecov.io/gh/go-xorm/xorm/pull/648?src=pr&el=tree#diff-Y2FjaGVfbHJ1Lmdv) | `40.32% <0%> (-2.45%)` | :arrow_down: | | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/648?src=pr&el=tree#diff-eG9ybS5nbw==) | `67.14% <0%> (-2.35%)` | :arrow_down: | | [session\_find.go](https://codecov.io/gh/go-xorm/xorm/pull/648?src=pr&el=tree#diff-c2Vzc2lvbl9maW5kLmdv) | `56.09% <0%> (-2.24%)` | :arrow_down: | | ... and [21 more](https://codecov.io/gh/go-xorm/xorm/pull/648?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/648?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/648?src=pr&el=footer). Last update [774f83c...9bd63bb](https://codecov.io/gh/go-xorm/xorm/pull/648?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny referenced this issue from a commit

2019-10-21 05:46:59 +00:00

improve update error when no conent to be updated (#648)

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#648