Revert "support reuse session to transaction" #651

lunny · 2017-07-23T01:43:36Z

lunny commented

2017-07-23 01:43:36 +00:00

Reverts go-xorm/xorm#650

codecov-io commented

2017-07-23 01:47:52 +00:00

(Migrated from github.com)

Codecov Report

Merging #651 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #651      +/-   ##
==========================================
- Coverage   48.08%   48.06%   -0.02%     
==========================================
  Files          34       34              
  Lines        8361     8359       -2     
==========================================
- Hits         4020     4018       -2     
  Misses       3856     3856              
  Partials      485      485

Impacted Files	Coverage Δ
session_tx.go	`91.52% <ø> (-0.28%)`	⬇️
xorm.go	`67.14% <0%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c412be2...fc865ac. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/651?src=pr&el=h1) Report > Merging [#651](https://codecov.io/gh/go-xorm/xorm/pull/651?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/c412be236502ca71315dd61dbd324f3706010f0c?src=pr&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/651/graphs/tree.svg?width=650&src=pr&token=yB5nO1krEe&height=150)](https://codecov.io/gh/go-xorm/xorm/pull/651?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #651 +/- ## ========================================== - Coverage 48.08% 48.06% -0.02% ========================================== Files 34 34 Lines 8361 8359 -2 ========================================== - Hits 4020 4018 -2 Misses 3856 3856 Partials 485 485 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/651?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [session\_tx.go](https://codecov.io/gh/go-xorm/xorm/pull/651?src=pr&el=tree#diff-c2Vzc2lvbl90eC5nbw==) | `91.52% <ø> (-0.28%)` | :arrow_down: | | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/651?src=pr&el=tree#diff-eG9ybS5nbw==) | `67.14% <0%> (ø)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/651?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/651?src=pr&el=footer). Last update [c412be2...fc865ac](https://codecov.io/gh/go-xorm/xorm/pull/651?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny referenced this issue from a commit

2019-10-21 05:46:59 +00:00

Revert "support reuse session to transaction (#650)" (#651) This reverts commit c412be236502ca71315dd61dbd324f3706010f0c.

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#651