improve count usage #654

lunny · 2017-07-25T08:45:43Z

lunny commented

2017-07-25 08:45:43 +00:00

Support total, err = testEngine.Where(cond).Table("userinfo_count").Count()

Support `total, err = testEngine.Where(cond).Table("userinfo_count").Count()`

codecov-io commented

2017-07-25 08:48:26 +00:00

(Migrated from github.com)

Codecov Report

Merging #654 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #654      +/-   ##
=========================================
+ Coverage   48.05%   48.1%   +0.05%     
=========================================
  Files          34      34              
  Lines        8374    8377       +3     
=========================================
+ Hits         4024    4030       +6     
+ Misses       3862    3860       -2     
+ Partials      488     487       -1

Impacted Files	Coverage Δ
statement.go	`61.68% <100%> (+0.26%)`	⬆️
session_stats.go	`46.2% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbc493d...affba3c. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/654?src=pr&el=h1) Report > Merging [#654](https://codecov.io/gh/go-xorm/xorm/pull/654?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/dbc493df5e34bf9a5b111c6fbe5e626d99a87134?src=pr&el=desc) will **increase** coverage by `0.05%`. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/654/graphs/tree.svg?height=150&width=650&src=pr&token=yB5nO1krEe)](https://codecov.io/gh/go-xorm/xorm/pull/654?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #654 +/- ## ========================================= + Coverage 48.05% 48.1% +0.05% ========================================= Files 34 34 Lines 8374 8377 +3 ========================================= + Hits 4024 4030 +6 + Misses 3862 3860 -2 + Partials 488 487 -1 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/654?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [statement.go](https://codecov.io/gh/go-xorm/xorm/pull/654?src=pr&el=tree#diff-c3RhdGVtZW50Lmdv) | `61.68% <100%> (+0.26%)` | :arrow_up: | | [session\_stats.go](https://codecov.io/gh/go-xorm/xorm/pull/654?src=pr&el=tree#diff-c2Vzc2lvbl9zdGF0cy5nbw==) | `46.2% <100%> (ø)` | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/654?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/654?src=pr&el=footer). Last update [dbc493d...affba3c](https://codecov.io/gh/go-xorm/xorm/pull/654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny referenced this issue from a commit

2019-10-21 05:46:59 +00:00

improve count usage (#654)

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#654