tests for close and add IsClosed() method #659

lunny · 2017-07-26T09:33:34Z

lunny commented

2017-07-26 09:33:34 +00:00

This also removed the unused code session.Init() in session.Close()

This also removed the unused code `session.Init()` in `session.Close()`

codecov-io commented

2017-07-26 09:40:12 +00:00

(Migrated from github.com)

Codecov Report

Merging #659 into master will increase coverage by 0.07%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #659      +/-   ##
=========================================
+ Coverage   48.22%   48.3%   +0.07%     
=========================================
  Files          34      34              
  Lines        8377    8378       +1     
=========================================
+ Hits         4040    4047       +7     
+ Misses       3848    3844       -4     
+ Partials      489     487       -2

Impacted Files	Coverage Δ
session.go	`48.63% <100%> (+0.08%)`	⬆️
session_schema.go	`54.29% <0%> (+1.84%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5a917d...44de5b0. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/659?src=pr&el=h1) Report > Merging [#659](https://codecov.io/gh/go-xorm/xorm/pull/659?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/a5a917d477c27830276b8dc88163170436789943?src=pr&el=desc) will **increase** coverage by `0.07%`. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/659/graphs/tree.svg?width=650&token=yB5nO1krEe&height=150&src=pr)](https://codecov.io/gh/go-xorm/xorm/pull/659?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #659 +/- ## ========================================= + Coverage 48.22% 48.3% +0.07% ========================================= Files 34 34 Lines 8377 8378 +1 ========================================= + Hits 4040 4047 +7 + Misses 3848 3844 -4 + Partials 489 487 -2 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/659?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [session.go](https://codecov.io/gh/go-xorm/xorm/pull/659?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `48.63% <100%> (+0.08%)` | :arrow_up: | | [session\_schema.go](https://codecov.io/gh/go-xorm/xorm/pull/659?src=pr&el=tree#diff-c2Vzc2lvbl9zY2hlbWEuZ28=) | `54.29% <0%> (+1.84%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/659?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/659?src=pr&el=footer). Last update [a5a917d...44de5b0](https://codecov.io/gh/go-xorm/xorm/pull/659?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny referenced this issue from a commit

2019-10-21 05:46:59 +00:00

tests for close and add IsClosed() method (#659)

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#659