xorm/xorm
xorm/xorm
63
356
Fork 206
Code Issues 370 Pull Requests 19 Actions 35 Releases 35 Activity

Nil ptr is nullable #661

Closed
oherych wants to merge 4 commits from unknown repository into master
pull from: unknown repository
merge into: xorm:master
Conversation 3 Commits 4 Files Changed 2 +50 -8
oherych commented 2017-07-26 15:10:50 +00:00 (Migrated from github.com)
Copy Link

test for this pull request https://github.com/go-xorm/xorm/pull/531

test for this pull request https://github.com/go-xorm/xorm/pull/531
codecov-io commented 2017-07-26 15:15:45 +00:00 (Migrated from github.com)
Copy Link

Codecov Report

Merging #661 into master will increase coverage by 0.12%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #661      +/-   ##
==========================================
+ Coverage    48.3%   48.42%   +0.12%     
==========================================
  Files          34       34              
  Lines        8378     8386       +8     
==========================================
+ Hits         4047     4061      +14     
+ Misses       3844     3838       -6     
  Partials      487      487
Impacted Files Coverage Δ
helpers.go 53.42% <55.55%> (+1.6%) ⬆️
xorm.go 67.14% <0%> (ø) ⬆️
engine.go 54.5% <0%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c2d924...ec47a11. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/661?src=pr&el=h1) Report > Merging [#661](https://codecov.io/gh/go-xorm/xorm/pull/661?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/7c2d9247948f0e49fab931ef14bc3638b92e8738?src=pr&el=desc) will **increase** coverage by `0.12%`. > The diff coverage is `55.55%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/661/graphs/tree.svg?token=yB5nO1krEe&width=650&src=pr&height=150)](https://codecov.io/gh/go-xorm/xorm/pull/661?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #661 +/- ## ========================================== + Coverage 48.3% 48.42% +0.12% ========================================== Files 34 34 Lines 8378 8386 +8 ========================================== + Hits 4047 4061 +14 + Misses 3844 3838 -6 Partials 487 487 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/661?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [helpers.go](https://codecov.io/gh/go-xorm/xorm/pull/661?src=pr&el=tree#diff-aGVscGVycy5nbw==) | `53.42% <55.55%> (+1.6%)` | :arrow_up: | | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/661?src=pr&el=tree#diff-eG9ybS5nbw==) | `67.14% <0%> (ø)` | :arrow_up: | | [engine.go](https://codecov.io/gh/go-xorm/xorm/pull/661?src=pr&el=tree#diff-ZW5naW5lLmdv) | `54.5% <0%> (+0.38%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/661?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/661?src=pr&el=footer). Last update [7c2d924...ec47a11](https://codecov.io/gh/go-xorm/xorm/pull/661?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
codecov-io commented 2017-07-26 15:15:45 +00:00 (Migrated from github.com)
Copy Link

Codecov Report

Merging #661 into master will increase coverage by 0.12%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #661      +/-   ##
==========================================
+ Coverage    48.3%   48.42%   +0.12%     
==========================================
  Files          34       34              
  Lines        8378     8386       +8     
==========================================
+ Hits         4047     4061      +14     
+ Misses       3844     3838       -6     
  Partials      487      487
Impacted Files Coverage Δ
helpers.go 53.42% <55.55%> (+1.6%) ⬆️
xorm.go 67.14% <0%> (ø) ⬆️
engine.go 54.5% <0%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c2d924...ec47a11. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/661?src=pr&el=h1) Report > Merging [#661](https://codecov.io/gh/go-xorm/xorm/pull/661?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/7c2d9247948f0e49fab931ef14bc3638b92e8738?src=pr&el=desc) will **increase** coverage by `0.12%`. > The diff coverage is `55.55%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/661/graphs/tree.svg?token=yB5nO1krEe&src=pr&width=650&height=150)](https://codecov.io/gh/go-xorm/xorm/pull/661?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #661 +/- ## ========================================== + Coverage 48.3% 48.42% +0.12% ========================================== Files 34 34 Lines 8378 8386 +8 ========================================== + Hits 4047 4061 +14 + Misses 3844 3838 -6 Partials 487 487 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/661?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [helpers.go](https://codecov.io/gh/go-xorm/xorm/pull/661/diff?src=pr&el=tree#diff-aGVscGVycy5nbw==) | `53.42% <55.55%> (+1.6%)` | :arrow_up: | | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/661/diff?src=pr&el=tree#diff-eG9ybS5nbw==) | `67.14% <0%> (ø)` | :arrow_up: | | [engine.go](https://codecov.io/gh/go-xorm/xorm/pull/661/diff?src=pr&el=tree#diff-ZW5naW5lLmdv) | `54.5% <0%> (+0.38%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/661?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/661?src=pr&el=footer). Last update [7c2d924...ec47a11](https://codecov.io/gh/go-xorm/xorm/pull/661?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
lunny commented 2018-04-10 03:31:09 +00:00
Copy Link

please resolve conflicts.

please resolve conflicts.
lunny modified the milestone from 0.8 to 0.8.2 2019-10-21 03:49:16 +00:00
lunny modified the milestone from 0.8.2 to 1.3.0 2020-01-20 08:27:25 +00:00
lunny closed this pull request 2021-06-06 12:30:46 +00:00
lunny removed this from the 1.3.0 milestone 2021-06-06 13:06:03 +00:00
lunny referenced this issue from a commit 2021-07-06 15:20:17 +00:00
Nil ptr is nullable (#1919)

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backport/done

   
backport/v1

   
blocked
  
db
oracle

  
db
sqlserver

  
duplicate
  
feature
cache

  
frontport/done

   
frontport/main

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependencies

  
kind
docs

  
kind
driver

  
kind
enhancement

  
kind
feature

  
kind
performance

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
testing

  
need
feedback

  
need
test

  
proposal:accepted

   
RaspBerry Pi

   
regression

   
skip-changelog

   
upstream

   
wip

   
wontfix
No Label
backport/done
backport/v1
blocked
db
oracle
db
sqlserver
duplicate
feature
cache
frontport/done
frontport/main
invalid
kind
breaking
kind
bug
kind
build
kind
dependencies
kind
docs
kind
driver
kind
enhancement
kind
feature
kind
performance
kind
proposal
kind
question
kind
refactor
kind
testing
need
feedback
need
test
proposal:accepted
RaspBerry Pi
regression
skip-changelog
upstream
wip
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#661
No description provided.
Delete Branch "unknown repository"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?