fix bug on new engine #679

lunny · 2017-08-07T03:29:05Z

lunny commented

2017-08-07 03:29:05 +00:00

will fix #678

codecov-io commented

2017-08-07 03:32:52 +00:00

(Migrated from github.com)

Codecov Report

Merging #679 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #679      +/-   ##
==========================================
+ Coverage   49.06%   49.07%   +<.01%     
==========================================
  Files          34       34              
  Lines        8315     8316       +1     
==========================================
+ Hits         4080     4081       +1     
  Misses       3755     3755              
  Partials      480      480

Impacted Files	Coverage Δ
xorm.go	`67.6% <100%> (+0.46%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fdfa8d...01dcf48. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/679?src=pr&el=h1) Report > Merging [#679](https://codecov.io/gh/go-xorm/xorm/pull/679?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/0fdfa8d8de76afabf7dc5348bb245916eda04c61?src=pr&el=desc) will **increase** coverage by `<.01%`. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/679/graphs/tree.svg?width=650&height=150&src=pr&token=yB5nO1krEe)](https://codecov.io/gh/go-xorm/xorm/pull/679?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #679 +/- ## ========================================== + Coverage 49.06% 49.07% +<.01% ========================================== Files 34 34 Lines 8315 8316 +1 ========================================== + Hits 4080 4081 +1 Misses 3755 3755 Partials 480 480 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/679?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/679?src=pr&el=tree#diff-eG9ybS5nbw==) | `67.6% <100%> (+0.46%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/679?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/679?src=pr&el=footer). Last update [0fdfa8d...01dcf48](https://codecov.io/gh/go-xorm/xorm/pull/679?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny referenced this issue from a commit

2019-10-21 05:46:59 +00:00

fix bug on new engine (#679)

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#679