add more error check on Get #680

lunny · 2017-08-07T08:47:44Z

lunny commented

2017-08-07 08:47:44 +00:00

No description provided.

codecov-io commented

2017-08-07 08:51:32 +00:00

(Migrated from github.com)

Codecov Report

Merging #680 into master will increase coverage by 0.01%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #680      +/-   ##
==========================================
+ Coverage   49.07%   49.08%   +0.01%     
==========================================
  Files          34       34              
  Lines        8316     8318       +2     
==========================================
+ Hits         4081     4083       +2     
+ Misses       3755     3754       -1     
- Partials      480      481       +1

Impacted Files	Coverage Δ
session_get.go	`41.1% <33.33%> (+0.73%)`	⬆️
xorm.go	`67.6% <0%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f43b290...036579f. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/680?src=pr&el=h1) Report > Merging [#680](https://codecov.io/gh/go-xorm/xorm/pull/680?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/f43b29056db99849f48f5c87c37ee42dfbc93e0d?src=pr&el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `33.33%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/680/graphs/tree.svg?height=150&width=650&token=yB5nO1krEe&src=pr)](https://codecov.io/gh/go-xorm/xorm/pull/680?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #680 +/- ## ========================================== + Coverage 49.07% 49.08% +0.01% ========================================== Files 34 34 Lines 8316 8318 +2 ========================================== + Hits 4081 4083 +2 + Misses 3755 3754 -1 - Partials 480 481 +1 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/680?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [session\_get.go](https://codecov.io/gh/go-xorm/xorm/pull/680?src=pr&el=tree#diff-c2Vzc2lvbl9nZXQuZ28=) | `41.1% <33.33%> (+0.73%)` | :arrow_up: | | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/680?src=pr&el=tree#diff-eG9ybS5nbw==) | `67.6% <0%> (ø)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/680?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/680?src=pr&el=footer). Last update [f43b290...036579f](https://codecov.io/gh/go-xorm/xorm/pull/680?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny referenced this issue from a commit

2019-10-21 05:46:59 +00:00

add more error check on Get (#680)

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#680