fix query string bug when value is nil #692

lunny · 2017-08-26T01:35:48Z

lunny commented

2017-08-26 01:35:48 +00:00

No description provided.

codecov-io commented

2017-08-26 01:37:06 +00:00

(Migrated from github.com)

Codecov Report

Merging #692 into master will decrease coverage by 0.01%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #692      +/-   ##
==========================================
- Coverage   49.15%   49.14%   -0.02%     
==========================================
  Files          34       34              
  Lines        8314     8314              
==========================================
- Hits         4087     4086       -1     
  Misses       3748     3748              
- Partials      479      480       +1

Impacted Files	Coverage Δ
session_raw.go	`56.7% <33.33%> (ø)`	⬆️
xorm.go	`67.6% <0%> (-1.41%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a10b5ab...06fcd88. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/692?src=pr&el=h1) Report > Merging [#692](https://codecov.io/gh/go-xorm/xorm/pull/692?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/a10b5aba4bb97b30daa74e7c0363d3084ede0514?src=pr&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `33.33%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/692/graphs/tree.svg?src=pr&height=150&width=650&token=yB5nO1krEe)](https://codecov.io/gh/go-xorm/xorm/pull/692?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #692 +/- ## ========================================== - Coverage 49.15% 49.14% -0.02% ========================================== Files 34 34 Lines 8314 8314 ========================================== - Hits 4087 4086 -1 Misses 3748 3748 - Partials 479 480 +1 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/692?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [session\_raw.go](https://codecov.io/gh/go-xorm/xorm/pull/692?src=pr&el=tree#diff-c2Vzc2lvbl9yYXcuZ28=) | `56.7% <33.33%> (ø)` | :arrow_up: | | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/692?src=pr&el=tree#diff-eG9ybS5nbw==) | `67.6% <0%> (-1.41%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/692?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/692?src=pr&el=footer). Last update [a10b5ab...06fcd88](https://codecov.io/gh/go-xorm/xorm/pull/692?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny commented

2017-08-26 01:38:36 +00:00

will fix #691

lunny referenced this issue from a commit

2019-10-21 05:46:59 +00:00

fix query string bug when value is nil (#692)

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#692